-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: fix #6913, feat($compiler): add support of v-local directive to provide a way to… #7325
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,166 @@ | ||
| import Vue from 'vue' | ||
|
|
||
| describe('Directive v-local', () => { | ||
| it('should work', () => { | ||
| const vm = new Vue({ | ||
| template: '<div><span v-local:v="foo.bar">{{v.baz}}</span></div>', | ||
| data: { | ||
| foo: { | ||
| bar: { | ||
| baz: 1 | ||
| } | ||
| } | ||
| } | ||
| }).$mount() | ||
| expect(vm.$el.innerHTML).toBe('<span>1</span>') | ||
| }) | ||
|
|
||
| it('should update', done => { | ||
| const vm = new Vue({ | ||
| template: '<div><span v-local:v="foo.bar">{{v.baz}}</span></div>', | ||
| data: { | ||
| foo: { | ||
| bar: { | ||
| baz: 1 | ||
| } | ||
| } | ||
| } | ||
| }).$mount() | ||
| expect(vm.$el.innerHTML).toBe('<span>1</span>') | ||
| vm.foo.bar.baz = 2 | ||
| waitForUpdate(() => { | ||
| expect(vm.$el.innerHTML).toBe('<span>2</span>') | ||
| vm.foo.bar.baz = 'a' | ||
| }).then(() => { | ||
| expect(vm.$el.innerHTML).toBe('<span>a</span>') | ||
| }).then(done) | ||
| }) | ||
|
|
||
| it('should work with v-if', done => { | ||
| const vm = new Vue({ | ||
| template: '<div><span v-if="v.show" v-local:v="foo.bar">{{v.baz}}</span></div>', | ||
| data: { | ||
| foo: { | ||
| bar: { | ||
| baz: 1, | ||
| show: true | ||
| } | ||
| } | ||
| } | ||
| }).$mount() | ||
| expect(vm.$el.innerHTML).toBe('<span>1</span>') | ||
| vm.foo.bar.show = false | ||
| waitForUpdate(() => { | ||
| expect(vm.$el.innerHTML).toBe('<!---->') | ||
| vm.foo.bar.baz = 2 | ||
| vm.foo.bar.show = true | ||
| }).then(() => { | ||
| expect(vm.$el.innerHTML).toBe('<span>2</span>') | ||
| }).then(done) | ||
| }) | ||
|
|
||
| it('should work with v-for', done => { | ||
| const vm = new Vue({ | ||
| template: '<div><span v-for="item in items" v-local:v="item.foo.bar">{{v.baz}}</span></div>', | ||
| data: { | ||
| items: [ | ||
| { | ||
| foo: { | ||
| bar: { | ||
| baz: 1 | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| }).$mount() | ||
| expect(vm.$el.innerHTML).toBe('<span>1</span>') | ||
| vm.items.push({ | ||
| foo: { | ||
| bar: { | ||
| baz: 2 | ||
| } | ||
| } | ||
| }) | ||
| waitForUpdate(() => { | ||
| expect(vm.$el.innerHTML).toBe('<span>1</span><span>2</span>') | ||
| vm.items.shift() | ||
| }).then(() => { | ||
| expect(vm.$el.innerHTML).toBe('<span>2</span>') | ||
| vm.items = [] | ||
| }).then(() => { | ||
| expect(vm.$el.innerHTML).toBe('') | ||
| }).then(done) | ||
| }) | ||
|
|
||
| it('should been called once', () => { | ||
| const spy = jasmine.createSpy() | ||
| const vm = new Vue({ | ||
| template: '<div><span v-local:v="getValue()">{{v.foo}}-{{v.bar}}</span></div>', | ||
| data: { | ||
| foo: { | ||
| bar: { | ||
| baz: 1 | ||
| } | ||
| } | ||
| }, | ||
| methods: { | ||
| getValue () { | ||
| spy() | ||
| return { | ||
| foo: this.foo.bar.baz + 1, | ||
| bar: this.foo.bar.baz + 2 | ||
| } | ||
| } | ||
| } | ||
| }).$mount() | ||
| expect(vm.$el.innerHTML).toBe('<span>2-3</span>') | ||
| expect(spy).toHaveBeenCalledTimes(1) | ||
| }) | ||
|
|
||
| it('should work with scoped-slot', done => { | ||
| const vm = new Vue({ | ||
| template: ` | ||
| <test ref="test"> | ||
| <template slot="item" slot-scope="props" v-local:v="props.text.foo.bar.baz"> | ||
| <span>{{ v }}</span> | ||
| </template> | ||
| </test> | ||
| `, | ||
| components: { | ||
| test: { | ||
| data () { | ||
| return { | ||
| items: [{ | ||
| foo: { | ||
| bar: { | ||
| baz: 1 | ||
| } | ||
| } | ||
| }] | ||
| } | ||
| }, | ||
| template: ` | ||
| <div> | ||
| <slot v-for="item in items" name="item" :text="item"></slot> | ||
| </div> | ||
| ` | ||
| } | ||
| } | ||
| }).$mount() | ||
| expect(vm.$el.innerHTML).toBe('<span>1</span>') | ||
| vm.$refs.test.items.push({ | ||
| foo: { | ||
| bar: { | ||
| baz: 2 | ||
| } | ||
| } | ||
| }) | ||
| waitForUpdate(() => { | ||
| expect(vm.$el.innerHTML).toBe('<span>1</span><span>2</span>') | ||
| vm.$refs.test.items = [] | ||
| }).then(() => { | ||
| expect(vm.$el.innerHTML).toBe('') | ||
| }).then(done) | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need another test for combining v-for, scoped slot and v-local together as scoped vFor is handled separately IIRC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some deeper thoughts,
v-localmight be harder than I originally estimated. The root problem is it adds a new way to introduce new variable in template. After this, we will have three way to introduce new variables:With 1 and 2 we already have some ordering issue, #6817. I would say more variable introduction isn't scalable in current implementation. For example,
<div v-local:items="foo.deep.prop" v-for="item in items">is still missing in test. And supporting such usage will require yet another patch ingenFor.