Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v-model): prevent double v-model update on functional components(#8436) #8580

Closed

Conversation

wildan2711
Copy link

@wildan2711 wildan2711 commented Jul 31, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Currently, when transforming data.model in createElement function, it does not check if the component is a functional component, causing a double update on v-model. This prevents double update on v-model in functional components by not transforming model when Ctor.options.functional is true.

fix #8436 and eventually vuetifyjs/vuetify#4460

prevent double v-model update on functional components by not transforming model when
Ctor.options.functional is true

fix vuejs#8436
@yyx990803
Copy link
Member

Thanks for the PR - unfortunately, this does not really fix the root cause (the double-merging would happen regardless of the wrapper being functional or not). A more complete fix was landed in 7b7164c.

@yyx990803 yyx990803 closed this Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

functional component wrapping with context.data causes v-model to update twice
2 participants