fix(types): avoid this in VueConstructor signature
#9173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HerringtonDarkholme Thanks! Can we add a test case for decorator usage? |
|
@ktsn Indeed. I found vue-class-component bug can be only reproduced in decorator usage, It requires us to switch on |
|
@HerringtonDarkholme I think it is fine. Do you have any concern about that? |
XadillaX
pushed a commit
to cnpm/bug-versions
that referenced
this pull request
Dec 10, 2018
loong-moon
pushed a commit
to loong-moon/vue
that referenced
this pull request
Dec 11, 2018
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
aJean
pushed a commit
to aJean/vue
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)Other information:
Fix vuejs/vue-class-component#294
Mixing
this,interface,extendsandnewsignature seems to be hairy in TypeScript. It is better to not rely onthis.