feat(compiler): switch to new removeWhitespace option (#9208)
#9217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
reviewed
Dec 26, 2018
| expect(ast.children[3].tag).toBe('i') | ||
| expect(ast.children[3].children[0].text).toBe('world') | ||
| expect(ast.children[4].type).toBe(3) | ||
| expect(ast.children[4].text).toBe('.\n Have fun!') |
There was a problem hiding this comment.
Shouldn't this newline be condensed to a single space?
There was a problem hiding this comment.
Oh yes, we need to handle this. I forgot to collapse these in the middle of a string.
I'm also wondering if we can have a better option name and values to better describe the behavior. Unlike the previous remove/preserve logic, the new logic also include collapsing. I'm not quite satisfied with removeWhitespace yet...Thoughts?
|
See #9208 (comment) |
|
Nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide
removeWhitespaceoption for smarter whitespace trimming. Resolves #9208.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
See #9208.
Other information:
Also added the missing test cases for the old
preserveWhitespaceoption.