Improve reset and allow waiting for data to be received #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 99.72% 99.73% +<.01%
==========================================
Files 14 14
Lines 368 373 +5
Branches 64 71 +7
==========================================
+ Hits 367 372 +5
Misses 1 1
Continue to review full report at Codecov.
|
- @posva/vuefire-core@2.2.0-alpha.0 - @posva/vuefire-test-helpers@1.3.0-alpha.0 - documentation@2.1.0-alpha.0 - vuefire@2.2.0-alpha.0 - vuexfire@3.2.0-alpha.0
|
merged locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83
The new
waitoption should be important for SSRDocumentation for
waitoption: https://deploy-preview-361--vuefire.netlify.com/api/vuefire.html#optionsIf you need this, could you please test it?. It has been released under the
nexttag on npm, you can install it by doingnpm i vuefire@nextoryarn add vuefire@next(orvuexfire)The documentation should be enough to understand how the
waitoption works, it's also used in the examples for vuefire and vuexfire. Thanks 🙏