Skip to content

Commit

Permalink
fix: correct homepage URLs in package.json (#2394)
Browse files Browse the repository at this point in the history
  • Loading branch information
@tolking
tolking authored Jun 1, 2020
1 parent 869eb8d commit 0854987
Show file tree
Hide file tree
Showing 16 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion packages/@vuepress/markdown-loader/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/markdown-loader#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/markdown-loader#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@vuepress/markdown/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/markdown#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/markdown#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@vuepress/plugin-active-header-links/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/plugin-active-header-links#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/plugin-active-header-links#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@vuepress/plugin-back-to-top/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/back-to-top#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/back-to-top#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@vuepress/plugin-google-analytics/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/plugin-google-analytics#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/plugin-google-analytics#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@vuepress/plugin-last-updated/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/plugin-last-updated#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/plugin-last-updated#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@vuepress/plugin-medium-zoom/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/plugin-medium-zoom#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/plugin-medium-zoom#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@vuepress/plugin-nprogress/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/plugin-nprogress#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/plugin-nprogress#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@vuepress/plugin-pwa/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/plugin-pwa#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/plugin-pwa#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@vuepress/plugin-register-components/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/plugin-register-components#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/plugin-register-components#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@vuepress/plugin-search/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/plugin-search#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/plugin-search#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@vuepress/shared-utils/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/shared-utils#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/shared-utils#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@vuepress/test-utils/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/test-utils#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/test-utils#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@vuepress/theme-default/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/theme-default#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/theme-default#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@vuepress/theme-vue/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"vue",
"vuepress"
],
"homepage": "https://github.com/vuejs/vuepress/packages/@vuepress/theme-vue#readme",
"homepage": "https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/theme-vue#readme",
"bugs": {
"url": "https://github.com/vuejs/vuepress/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion scripts/bootstrap.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ files.forEach(pkg => {
'bugs': {
'url': 'https://github.com/vuejs/vuepress/issues'
},
'homepage': `https://github.com/vuejs/vuepress/packages/@vuepress/${pkg}#readme`
'homepage': `https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/${pkg}#readme`
}
fs.writeFileSync(pkgPath, JSON.stringify(json, null, 2))
}
Expand Down

4 comments on commit 0854987

@ulivz
Copy link
Member

@ulivz ulivz commented on 0854987 Jun 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit message SHOULD NOT start with fix @bencodezen @tolking

@bencodezen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulivz I'd be curious what you would categorize this as. Theoretically this is something wrong that is broken. I understand it might not be directly related to core functionality, but it does fix a bug does it not?

@ulivz
Copy link
Member

@ulivz ulivz commented on 0854987 Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bencodezen This is a compromise.

CHANGELOG should consider what most users are concerned about and interested in. It seems that it belongs to the fix of DOC rather than the fix of function, CHANGELOG should be concise and only focus on functions. Otherwise, why don't users directly look at the commit history?

@tolking
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulivz Thanks, I'll take much more notice

Please sign in to comment.