Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme-default should support all pre-processor #1114

Closed
mrleblanc101 opened this issue Dec 17, 2018 · 5 comments
Closed

theme-default should support all pre-processor #1114

mrleblanc101 opened this issue Dec 17, 2018 · 5 comments

Comments

@mrleblanc101
Copy link

Feature request

Hi,
I extended theme-default with custom components.
Those components are SFC using scss as the pre-processor.
The issue is that I can't access variables i created in palette.styl.
If i rename palette.styl in palette.scss, theme-default ignore the file.
Same goes for index.styl.
Shouldn't the theme load the correct file depending on the user configuration ?

What problem does this feature solve?

This would let the user use his prefered pre-processor.
SASS/SCSS is far more popular than Stylus.

What does the proposed API look like?

How should this be implemented in your opinion?

Are you willing to work on this yourself?**

@janvennemann
Copy link
Contributor

janvennemann commented Dec 17, 2018

You can't mix and match stylus and scss (at least not in terms of variable access). And since the default theme uses stylus you need to use that when you extend the theme and want to access stylus defined variables.

You are free to use SASS/SCSS if you start from scratch with your own theme, though.

@mrleblanc101
Copy link
Author

Then, could we use css custom propriety (css-vars) for variables so they are available in both or that wouldn't work either ?

@ulivz
Copy link
Member

ulivz commented Dec 18, 2018

@ulivz ulivz closed this as completed Dec 18, 2018
@mrleblanc101
Copy link
Author

mrleblanc101 commented Dec 18, 2018

As said, I was able to use SCSS in my vue component, but since the default theme use stylus, there is no way to access the theme color.

@mrleblanc101
Copy link
Author

Is there a specific reason why you choose stylus instead of the more popular scss/sass ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants