feat(blog) add component as layout option for Tags/Categories #1139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* it seems that typically you'd have custom theme for blog plugin but it would be nice to define a layout component from the .vuepress/components registered components similar to how frontmatter can use these as layouts in normal scenarios.
ulivz
force-pushed
the
master
branch
5 times, most recently
from
316e022 to
1284944
Compare
|
Thanks for the work, but we have reimplemented the blog plugin. See: #36 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It seems that typically you'd have custom theme for the blog plugin but it would be nice to define a layout component from the
.vuepress/componentsdirectory similar to how you can specifylayoutin frontmatter normally.This allows the plugin to use tags and categories without the need for a custom theme.
Example usage here: https://github.com/darrenjennings/guuu.io/blob/feat/service-worker/docs/.vuepress/components/Tag.vue where I'm using the default theme and creating custom components that hook into and extend
@vuepress/theme-default/layouts/LayoutWhat kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
I am new to this codebase so I am unsure this was the best way to tackle this issue.