fix($theme-default): front matter prev / next links #1140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes bug introduced with vuejs#1068.
15 tasks
janvennemann
reviewed
Jan 8, 2019
| @@ -53,7 +53,18 @@ export function isActive (route, path) { | |||
| return routePath === pagePath | |||
| } | |||
|
|
|||
| function normalizedPagesMap (pages) { | |||
| return pages.reduce((map, page) => { | |||
There was a problem hiding this comment.
Just some thoughts i had while looking at this: Compute the map only once and update in dev mode when the site data changes. Some check like here and then recompute the map might work.
There was a problem hiding this comment.
seems a very good idea, but webpack hot module replacement is way outside my skill set. I guess I should add learning it to my 2019 new year's resolutions! Also, where do I save the page map, the site object seems like it's not currently passed in.
|
Thanks for incorporating a fix/revert in alpha.32. confirm my build issue is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bug introduced with #1068.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
Fixes bug in 1.0.0-alpha.30 where adding this front matter to top of page causes build to fail (assuming using default theme and the file /tutorial/README.md exists