Skip to content

[Feature @vuepress/plugin-blog] pageEnhancers add no exists page #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Feature @vuepress/plugin-blog] pageEnhancers add no exists page #1179

wants to merge 1 commit into from

Conversation

lhz960904
Copy link
Contributor

Summary
reason:when I create a blog theme, I need archive Page, my config is

module.exports = {
  // ...
  plugins: [
    ['@vuepress/blog', {
      pageEnhancers: [
        {
          when: ({ regularPath }) => regularPath === '/archive/',
          frontmatter: { layout: 'Archive' },
        }
      ]
    }]
  ]
}

but archive page is not success, because pulgin-blog just executing ctx.pagesforEach, so, my idea is add permalink parameter and filter noExistsPage to addPage。

// ... 
const noExistsPage = pageEnhancers.filter(it => it.permalink).map(it => ({ permalink: it.permalink }))
const extraPages = [
// ...
...noExistsPage
]

May be it is not good method, It's just a proposal. thanks

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@ulivz
Copy link
Member

ulivz commented Jan 10, 2019

Closing this PR in favor of #1180

@ulivz ulivz closed this Jan 10, 2019
@lhz960904
Copy link
Contributor Author

Closing this PR in favor of #1180
😃ok

@lhz960904 lhz960904 deleted the add-no-exists-page branch February 28, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants