Skip to content

Conversation

@haoqunjiang
Copy link
Member

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Several dependencies have been updated to their latest majors in this PR, most of them introduced insignificant breaking changes such as dropping support for Node v4, thus won't affect end users.

The most important one is css-loader from v0.28 to v2. This change fixes a vulnerability warning caused by js-yaml "~3.7.0" (the dependency chain: css-loader@^0.28.11 > cssnano@^3.10.0 > postcss-svgo "^2.1.1" > svgo@^0.7.0 > js-yaml "~3.7.0").

@timaschew
Copy link
Contributor

You have mixed three things in one commit:

  • updating dependencies
  • code style
  • changing logic (of the css loader)

@haoqunjiang
Copy link
Member Author

The code style change is caused by the pre-commit hook. Do I need to revert it?

As for the css-loader logic, it hasn't changed - it's just an API change due to the major version bump.

@timaschew
Copy link
Contributor

Oh then it’s perfect!

@ulivz ulivz merged commit 0970954 into vuejs:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants