Skip to content

fix($core): use stylus conditional assignment (close #2127) #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2020

Conversation

meteorlxy
Copy link
Member

@meteorlxy meteorlxy commented Jan 13, 2020

Summary

close #2127

What kind of change does this PR introduce? (check at least one)

  • Bugfix ?
  • Feature
  • Code style update
  • Refactor ?
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

Other information:

In fact, it's not a bug, but something can be enhanced.

Copy link
Collaborator

@billyyyyy3320 billyyyyy3320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to change the commit message to something like fix($core): make default preset variables overridable (close #2127) to explain 'what' instead of 'how'.

@meteorlxy
Copy link
Member Author

meteorlxy commented Feb 2, 2020

Yeah I agree with your point @newsbielt703 .

This PR is a little different, because the variables are already overridable. I just change the way to make the override looks better. (which fix an edge case in #2127 , but I think it's not a commonly used way)

So maybe it should be categorized as "refactor" rather than "fix"?

@billyyyyy3320
Copy link
Collaborator

@meteorlxy Totally agree 😉

@meteorlxy meteorlxy merged commit ffd45c2 into vuejs:master Feb 2, 2020
@meteorlxy meteorlxy deleted the fix/styles branch February 2, 2020 15:55
larionov pushed a commit to larionov/vuepress that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can not override config.styl globally
3 participants