Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($core): reference correct canonical Url frontmatter property (fix #2665) #2666

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

adamdehaven
Copy link
Contributor

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes

  • No

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@adamdehaven adamdehaven changed the title Fix #2665 by referencing correct canonicalUrl frontmatter property. Fix: #2665 Referencing correct canonical Url frontmatter property. Oct 15, 2020
@adamdehaven adamdehaven changed the title Fix: #2665 Referencing correct canonical Url frontmatter property. fix($core): #2665 Referencing correct canonical Url frontmatter property. Oct 15, 2020
@d-pollard d-pollard self-requested a review October 15, 2020 16:30
Copy link
Collaborator

@d-pollard d-pollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@d-pollard d-pollard requested a review from bencodezen October 15, 2020 16:31
@billyyyyy3320 billyyyyy3320 changed the title fix($core): #2665 Referencing correct canonical Url frontmatter property. fix($core): reference correct canonical Url frontmatter property (fix #2665) Oct 15, 2020
Copy link
Collaborator

@billyyyyy3320 billyyyyy3320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@billyyyyy3320 billyyyyy3320 merged commit fbf5e5d into vuejs:master Oct 15, 2020
@adamdehaven
Copy link
Contributor Author

@d-pollard curious, does this replace the code in the current 1.7.0 or will it be in a future patch? (and if future, when?)

@adamdehaven adamdehaven deleted the issue-2665-canonicalUrl-fix branch October 15, 2020 16:55
@d-pollard
Copy link
Collaborator

It'll probably be a different patch, so we'll need to update the docs once the release. Will try to get it in ASAP

@adamdehaven
Copy link
Contributor Author

Ah ok - the docs are correct in the frontmatter.canonicalUrl reference. The only thing that would need to be updated is the version number 👍

@d-pollard
Copy link
Collaborator

@adamdehaven - this should be out now with version 1.7.1

@d-pollard
Copy link
Collaborator

docs updated too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants