enhancing DocSearch integration with language #697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to introduce the new way DocSearch will handle search on different languages for vuepress.
It will not more be needed to use the URL as it might introduce issue. We will grab it ourselves from the DOM (attribute
lang
).You can now update the vuepress website (couldn't find the website's repo):
Add a search input in your page if you don't have any yet. Then update the inputSelector value in JS snippet to a CSS selector that targets your search input field.
Replace $LANG with the lang you want to search on.
So as of today you have:
en-US
,zh-CN
What kind of change does this PR introduce? (check at least one)
We do update the Documentation's references.
Does this PR introduce a breaking change? (check one)
CC #686