UPDATE for Vue3 ( = vuex 4.x, vue-router 4.x) #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danktuary
reviewed
Dec 30, 2020
Akryum
reviewed
Dec 30, 2020
Spice-Z
commented
Jan 5, 2021
Comment on lines
+62
to
+64
| "vue": "^3.0.5", | ||
| "vue-router": "^4.0.2", | ||
| "vuex": "^4.0.0-rc.2" |
There was a problem hiding this comment.
I want to update other dependencies, but that should be other PR to keep it simple...
posva
requested changes
Jan 7, 2021
| router, | ||
| render: (h) => h('router-view') | ||
| }).$mount() | ||
| const rootEl = document.createElement('div') |
There was a problem hiding this comment.
Wouldn't it be easier and safer to use vue test utils?
There was a problem hiding this comment.
Ok, I will try to use vue test utils!
(Actually, I have not use it yet 😅 )
|
Thank you so much for the PR! I've added test for the time traveling and now the coverage is 100% 🙌 As @posva mentioned, I think we should use vue-test-utils ideally but since it's quite small test, I would go ahead and merge this one, then maybe add playground to do the final manual test, then I think we're ready to go 👍 |
kiaking
approved these changes
Feb 4, 2021
kiaking
added a commit
that referenced
this pull request
Feb 5, 2021
Co-authored-by: Kia King Ishii <kia.king.08@gmail.com>
kiaking
added a commit
that referenced
this pull request
Feb 5, 2021
Co-authored-by: Kia King Ishii <kia.king.08@gmail.com>
kiaking
added a commit
that referenced
this pull request
Feb 5, 2021
Co-authored-by: Kia King Ishii <kia.king.08@gmail.com>
kiaking
added a commit
that referenced
this pull request
Feb 5, 2021
Co-authored-by: Kia King Ishii <kia.king.08@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use vuex-router-sync in Vue 3.x, I updated vue, vuex and vue-router!
Changed src and test,
currently the test is not perfect, help...😭About vue-routers's afterEachTo mutate latest route info, this package using vue-router'safterEachfunction.But vue-router v4.x only export add function, and doesn't export any list that registered afterEach.I want to testunsynccorrectly remove router's afterEach hook, but I have no idea.About vuex's watchTo sync router on store change, this package using vuex'swatchfunctionBut I can't find a way to confirm what is registered in watch hooks!I want to testunsynccorrectly remove vuex's watch hook, but I have no idea...About unsync test