Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type checking is broken in Vue components when using mapping helpers #1119

Closed
Demivan opened this issue Jan 4, 2018 · 1 comment · Fixed by #1639
Closed

Type checking is broken in Vue components when using mapping helpers #1119

Demivan opened this issue Jan 4, 2018 · 1 comment · Fixed by #1639
Assignees
@ktsn
Labels
enhancement New feature or request types Related to typings only

Comments

@Demivan
Copy link

Demivan commented Jan 4, 2018 •
edited
Loading

Version

3.0.1

Reproduction link

#1105

Steps to reproduce

  1. Create new Vue component.
  2. In jsconfig.json (tsconfig.json) enable strict mode and js checking
  3. Add mapState or mapActions to the component

What is expected?

Type checking should work.
Intellisense should suggest actions mapped using mapActions and suggest data mapped using mapState
image

What is actually happening?

Type checking stops working.
Intellisense is not suggesting mapped actions and state.
image

This is due to mapState and mapActions returning Dictionary<any>
I created pull request that fixes this for me: #1105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktsn ktsn

Labels
enhancement New feature or request types Related to typings only
Projects
None yet
Milestone
No milestone
3 participants
@ktsn @Demivan @bmdalex