Use keyof to improve type inference in helpers #1105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demivan
force-pushed
the
feature/improve-helpers-typings
branch
from
93b5b5f to
7434b48
Compare
|
Thank you for the contribution. However I'm actually just making a major update for helper types which includes the fix to this problem and improvements to use strictly typed getters/actions/mutations. (See #1121) Sorry for the inconvenience. I hope you did not mind to use #1121 as the fix for this problem. |
|
Glad to hear that. #1121 works fine for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using map helpers (
mapState,mapMutations,mapGettersormapActions) breaks type checking in Vue components.This pull request uses
keyofTypescript 2.1 feature to fix this.Before change:
After change:
Breaking change: When using functions as mappings, first parameter (
Commit,Dispatch) type is not inferred, but it is type-checked only.