add warnings when the different namespaced modules has the same names… #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsn
requested changes
May 21, 2019
src/store.js
Outdated
| if (process.env.NODE_ENV !== 'production') { | ||
| console.error(`[vuex] duplicate namespace ${namespace} for the namespaced module ${path.join('/')}`) | ||
| } | ||
| return |
There was a problem hiding this comment.
Don't return here please. It will change the current behavior which need major version bump.
There was a problem hiding this comment.
Yes,I see.
I have removed the return.Thanks.
ktsn
reviewed
May 21, 2019
src/store.js
Outdated
| @@ -301,6 +301,12 @@ function installModule (store, rootState, path, module, hot) { | |||
|
|
|||
| // register in namespace map | |||
| if (module.namespaced) { | |||
| const existedModule = store._modulesNamespaceMap[namespace] | |||
| if (existedModule) { | |||
| if (process.env.NODE_ENV !== 'production') { | |||
There was a problem hiding this comment.
Can we merge both if statement into one so that uglify will remove entire statement on production build?
There was a problem hiding this comment.
Yes, thanks.
I have changed that.
ktsn
approved these changes
May 22, 2019
|
Thank you! |
|
Thanks again! 💚 |
This was referenced Nov 18, 2019
This was referenced Jan 21, 2020
This was referenced Mar 1, 2020
This was referenced Mar 12, 2020
This was referenced Mar 26, 2020
This was referenced Apr 1, 2020
vaga
pushed a commit
to vaga/vuex
that referenced
this pull request
Apr 20, 2020
…names… (vuejs#1554) * add warnings when the different namespaced modules has the same namespace * Add warnings when duplicate namespace for different namespaced modules * Add warnings when duplicate namespace, merge if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add warnings when the different namespaced modules has the same namespace.
There is a situation that different namespaced modules could have the same namespace, so when in the method of installModule, generate store._modulesNamespaceMap, the follow module will override the before module.
For example:
the module m1 has the namespace 'm1',
the module m2/m1 has the same namespace 'm1'
so in the store._modulesNamespaceMap the module m2/m1 will override the module m1