Persistent app drawer does not work when combined with md-right #1204
Assignees
Labels
Comments
|
Hey, can you please provide your code? |
|
@Samuell1 Here's a codepen https://codepen.io/bluwoh/pen/KyBoeY If you remove the code for the left drawer, I think you can see what's happening here. It looks like the md-right attribute was never designed to work with a persistent drawer, only a temporary one. |
|
I forgot to think about persistent right drawers. I will improve this ASAP! |
|
@marcosmoura So what? Does this feature implemented? |
|
@marcosmoura Bro, tell something |
marcosmoura
pushed a commit
that referenced
this issue
May 13, 2018
* fix(MdApp): right drawer BREAKING CHANGE: Replace useless props `mdLeft` with `!this.mdRight` fix #1204 * fix(MdAppDrawer): right drawer supporting BREAKING CHANGE: no more than one drawer in a MdApp * fix(MdDrawerRightPrevious): right drawer styles use an previous element for styling container with right drawer with similar css codes * fix(MdDrawer): Temporary style * fix(MdAppSideDrawer): correct component name * fix(MdApp): reactive persistent drawer fully reactive drawer
|
So this comment in the docs for the "App"-component is now wrong I assume? Bummer :( "md-app-drawer: Places the drawer panel, that also accepts any options from the md-drawer. You can have a left or right placed drawers. Or both." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
md-app-drawercomponent does not push content over in persistent mode when it is set to the right side. Instead, it just opens atop of the content, partially covering it. There should also be a small border on the left edge like its left-drawer counterpart.The text was updated successfully, but these errors were encountered: