-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MdSelect] options in disabled groups are selectable #1286
Labels
Comments
I am still very new to this codebase, but I suspect that if this line were changed from checking "this.disabled" to "this.isDisabled" it would give the correct behavior:
My reasoning is that isDisabled() accounts for the injected "MdOptgroup" property, which appears to allow the component to inherit whether or not it is disabled based on the parent component. |
@hiddenwaffle thanks, that helps! |
marcosmoura
pushed a commit
that referenced
this issue
Dec 22, 2017
* fix(MdSelect): make options in disabled groups un-selectable fix #1286 * fix(MdSelect): make multiple selection checkboxes effective * style(MdOption): remove empty lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
Check the official documentation, and scroll down to "Disabled" example area. Select the disabled groups.
Which browser?
vue-material@1.0.0-beta-7
What is expected?
Those options in disabled groups should be un-selectable.
What is actually happening?
You can select the options in the disabled group.
Reproduction Link
official documentation
The text was updated successfully, but these errors were encountered: