Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MdMenu] does not close in chrome/iOS #1503

Closed
oeway opened this issue Feb 10, 2018 · 7 comments
Closed

[MdMenu] does not close in chrome/iOS #1503

oeway opened this issue Feb 10, 2018 · 7 comments

Comments

@oeway
Copy link

oeway commented Feb 10, 2018

I used MdMenu in a website, it works with desktop chrome, but when I open it in a ios version of chrome, the menu does not close when I click outside or clicked one item. The same happened with Safari/iOS version. I can't reproduce it with the mobile emulator in chrome dev tools. Not sure what happened.

@oeway oeway changed the title [MdMenu] do not close in chrome/iOS [MdMenu] does not close in chrome/iOS Feb 10, 2018
@Samuell1
Copy link
Member

Can you reproduce it on https://www.browserstack.com ?

@wpots
Copy link

wpots commented Mar 26, 2018

I think this issue is unresolved:
To reproduce open https://vuematerial.io/components/menu/ on the iPhone simulator (tested on iOS 10) or on an iPhone 7 with iOS 10, click on any of the options to open a menu (eg the first option "bottom start"). Now click/touch anywhere outside of the menu that just popped up... the menu will not close
Happens on chrome, safari and firefox on iOS.
Btw the menus do close on Android devices

@csteeg
Copy link
Contributor

csteeg commented Mar 27, 2018

@Samuell1 could you please re-open the issue? It's reproducable on the url @wozturk mentioned on browserstack as well #os=iOS&os_version=9.0&device=iPhone+6S&device_browser=safari)
The menus only close when opening other menus, there is no other way to close the menus on iOS

@Samuell1 Samuell1 reopened this Mar 27, 2018
@Samuell1
Copy link
Member

Maybe its solved here: #1588

@wpots
Copy link

wpots commented Mar 27, 2018

@Samuell1 I think #1588 is an issue about the links inside the menu. These seem to work fine when implemented correctly. This issue is about being able to dismiss the popup menu by clicking outside of the box, which isn't working on iOS

@Samuell1
Copy link
Member

Samuell1 commented Mar 27, 2018

@wpots I missclicked and posted a id to issue not to a PR.

This should solve any problems with clicking outside too #1630

csteeg pushed a commit to csteeg/vue-material that referenced this issue Mar 27, 2018
csteeg pushed a commit to csteeg/vue-material that referenced this issue Mar 27, 2018
@csteeg
Copy link
Contributor

csteeg commented Mar 27, 2018

@Samuell1 the branch fix/mdmenu/md-close-on-click does not fix this issue. It still doesn't close when clicking outside the menu.

I found an explanation on stackoverflow: https://stackoverflow.com/a/17490775/336130 and created a pull request with a fix for this.

Another (cleaner) solution would be to set the pointer as a cursor on the body element in base.scss, but this would not fix it for all click events that will be registered in the future (it would fix this menu issue though, since that one subscribes to the body element click event)

marcosmoura pushed a commit that referenced this issue Mar 28, 2018
…nts (#1634)

* Fix for issue #1503 -> ios devices do not trigger click events on 'non-clickable' elements

* Removed package-lock.json
@Samuell1 Samuell1 reopened this Apr 3, 2018
@Samuell1 Samuell1 closed this as completed Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants