Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MdTable] selectable count after removing item(s) #1610

Closed
osamaz26 opened this issue Mar 18, 2018 · 4 comments · Fixed by #1616
Closed

[MdTable] selectable count after removing item(s) #1610

osamaz26 opened this issue Mar 18, 2018 · 4 comments · Fixed by #1616
Labels

Comments

@osamaz26
Copy link

When i'm trying to remove one or more items from MdTable by changing source, i found that the removed items are still existed somewhere because SelectAll button is showing the count of removed items.

I'm using 1.0.0-beta8 version and table has md-selectable="multiple" flag with SelectAll button.

if checked the code and found this line in MdTableRow is preventing removing item from selectable array.
line number 125.
if (!this.hasMultipleSelection) {
return
}
I'm not sure if there is another way to remove item(s) from table and fix selectable items when clicking on SelectAll button.

@VdustR
Copy link
Member

VdustR commented Mar 19, 2018

I think this was fixed with #1496. Would you check it with dev branch or give me your reproduction code to let me confirm this?

@osamaz26
Copy link
Author

I created a small demo in codepen that using last release 1.0.0-beta8
https://codepen.io/osamaz26/pen/XEpozo
The main issue is with SelectAll button that is always shown.

I will check dev branch.

@osamaz26
Copy link
Author

I checked your last commit and everything works fine.
Thanks

@Amikre
Copy link

Amikre commented Jun 8, 2018

Hello @osamaz26 is there any way to contact you?
i have something to talk to you about privately but i don't see any email to reach you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants