Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MdTabs] property "exact" #1644

Closed
El4a opened this issue Mar 29, 2018 · 0 comments · Fixed by #1651
Closed

[MdTabs] property "exact" #1644

El4a opened this issue Mar 29, 2018 · 0 comments · Fixed by #1651

Comments

@El4a
Copy link

El4a commented Mar 29, 2018

Steps to reproduce

Implement navigation with tabs
<md-tabs md-sync-route md-alignment="fixed"> <md-tab md-label="Drinks" to="/" id='tab_drinks' exact></md-tab> <md-tab md-label="Orders" to="/orders" id='tab_orders'></md-tab> <md-tab md-label="FAQ" to="/faq" id='tab_faq'></md-tab> </md-tabs>

Which browser?

Vue: 2.52
Vue-router: 3.0.1
vue-material: 1.0.0-beta1

What is expected?

The docs of vue-material on the tabs page state:

All options of router-link can be simply used here.

An option of router-link is de "exact" property.
image

(https://router.vuejs.org/en/api/router-link.html)

I expected this to work when using the tabs with the md-sync-route property and the "to" property. So I expected my default '/' to not have the "router-link-active" class.

What is actually happening?

The default tab '/' still has the "router-link-active" class.

@VdustR VdustR changed the title Md-tabs: property "exact" [MdTabs] property "exact" Mar 29, 2018
Samuell1 pushed a commit that referenced this issue Jul 27, 2018
* fix(MdTab): exact router

fix exact router for active class

fix #1644

* fix(MdList): non-exact router active style

keep non-exact list item active when matched

* fix(MdBottomBar router): elegant router with active class

better router active with class instead of comparing `to` prop

* fix(MdTabs): elegant router with active class

better router active with class instead of comparing `to` prop

* fix(MdBottomBar): fix bugs

prevent active bar item directly in sync route mode

* docs(WithRouter): discriptions about working with vue router

* fix(MdTabs): better setIndicatorStyles performance with throttling

* fix(MdTabs): fix bugs

* docs(TabRouter): Better example

Remove tabs in tabs because that's a bad idea

* docs(TabRouter): remove unused codes

* feat(MdSteppers): elegant router with active class

better router active with class instead of comparing `to` prop

* docs(WithRouter): add md-step

* feat(MdStep): support all router-link props

* refactor(MdThrottling): reduce duplicated code for getting options

* fix(MdThrottling): typo

* fix(routes): doc production mapRoutes method replace string

* refactor(MdButton): lint complexity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants