Router link components improvement #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix exact router for active class fix #1644
keep non-exact list item active when matched
better router active with class instead of comparing `to` prop
better router active with class instead of comparing `to` prop
prevent active bar item directly in sync route mode
VdustR
changed the title
Remove tabs in tabs because that's a bad idea
better router active with class instead of comparing `to` prop
VdustR
changed the title
Samuell1
approved these changes
Apr 10, 2018
marcosmoura
requested changes
May 15, 2018
src/core/utils/MdThrottling.js
Outdated
|
|
||
|
|
||
| export default (fn, time, option) => { | ||
| const leading = option ? |
There was a problem hiding this comment.
Those two functions are exactly the same.
| @@ -0,0 +1,11 @@ | |||
| export default { | |||
There was a problem hiding this comment.
Why recreate the MdRouterLink props if we can read them from Vue Router?
There was a problem hiding this comment.
I can't make it work with only MdRouterLinkProps
marcosmoura
approved these changes
May 17, 2018
marcosmoura
requested changes
May 17, 2018
| @@ -45,7 +45,7 @@ export const routes = [ | |||
| page: 'Components/Datepicker/Datepicker.vue' | |||
| }, | |||
| { | |||
| path: '/components/steppers/:optional?', | |||
| path: '/components/steppers/:optional?/:sub?', | |||
There was a problem hiding this comment.
Is this :sub? needed? It's breaking the 'docs-build' task.
There was a problem hiding this comment.
Yes, they are for sub-subpages.
This was referenced Aug 9, 2018
Closed
marcosmoura
added a commit
that referenced
this pull request
May 11, 2019
* origin: (55 commits) fix(MdSvgLoader): svg loader for invalid / missing mimetype (#1942) docs(Icon): fix minor typo (#1973) fix(MdRouterLink): new router-link registration name (#1978) chore: apply discord vanity URL (#1927) docs(ROADMAP.md): replace dead slack invite link with discord invite link (#1924) docs(Table): fix grammar issues (#1902) feat: router link components improvements (#1651) fix(MdTable): recalculate fixed header width on data changes (#1877) fix(MdDialogContent): missing theme class (#1876) docs(Elevation and Layout): Typos fixed and improved documentation. (#1878) fix(MdTable): nextTick selection data (#1874) docs(BottomBar): fix typo (#1875) docs(MdButton): escape a tag (#1872) docs(Input): typos and correction chore: upgrade dependencies fix(MdField): remove firefox required box-shadow feat: disable complexity rules for some methods fix(MdProgressSpinner): fix CSP error (#1850) fix: MdBadge do not accept color #1854 issue (#1856) fix: fix the repeated generated css theme classes if there is multiple themes defined (#1784) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<router-link>props excepttagvia mixins.setIndicatorStyles.calculateStepperPos.fix #1644