Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MdApp): child.data.attrs is undefined #1762

Merged
merged 2 commits into from
May 19, 2018
Merged

fix(MdApp): child.data.attrs is undefined #1762

merged 2 commits into from
May 19, 2018

Conversation

Pwntus
Copy link
Contributor

@Pwntus Pwntus commented May 19, 2018

Fixes #1741

  • child.data.attrs needs to be checked for existence.
  • Broken out into a separate function called generateAttrKeys to avoid the following ESLint complexity error (limit at 6):
vue-material/src/components/MdApp/MdApp.vue
38:24  error  Arrow function has a complexity of 8  complexity

@marcosmoura marcosmoura merged commit ffee13d into vuematerial:dev May 19, 2018
@snyk-bot snyk-bot mentioned this pull request Feb 13, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmoura marcosmoura marcosmoura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pwntus @marcosmoura