Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MdApp): child.data.attrs is undefined #1762

Merged
merged 2 commits into from
May 19, 2018
Merged

fix(MdApp): child.data.attrs is undefined #1762

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11f7e76
fix(MdApp): TypeError: child.data.attrs is undefined
Pwntus May 18, 2018
e459c84
fix(MdApp): add generateAttrKeys function to adhere ESLint complexity…
Pwntus May 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/components/MdApp/MdApp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,21 @@
return (data && componentTypes.includes(data.slot)) || isValidChild(componentOptions)
}

function generateAttrKeys (attrs) {
return JSON.stringify({
'persistent': attrs && attrs['md-persistent'],
'permanent': attrs && attrs['md-permanent']
})
}

function buildSlots (children, context, functionalContext, options, createElement) {
let slots = []

let hasDrawer = false

if (children) {
children.forEach(child => {
/* eslint-enable */
const data = child.data
const componentOptions = child.componentOptions

Expand All @@ -53,10 +61,7 @@

hasDrawer = true
child.data.slot += `-${isRight ? 'right' : 'left'}`
child.key = JSON.stringify({
'persistent': child.data.attrs['md-persistent'],
'permanent': child.data.attrs['md-permanent']
})
child.key = generateAttrKeys(data.attrs)

createRightDrawer(isRight)
}
Expand Down