Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

docs(plugin-mathjax): update macros code demo #19

Merged
merged 4 commits into from
Feb 1, 2020
Merged

docs(plugin-mathjax): update macros code demo #19

merged 4 commits into from
Feb 1, 2020

Conversation

franklinqin0
Copy link
Contributor

The old code mathjax: { gives me a lint error, thus I mimicked the code in "Usage" to fix error.

Summary

Which package does this PR involve? (check one)

  • [ x ] root project
  • vuepress-plugin-clean-urls
  • vuepress-plugin-container
  • vuepress-plugin-dehydrate
  • vuepress-plugin-medium-zoom
  • vuepress-plugin-named-chunks
  • vuepress-plugin-nprogress
  • vuepress-plugin-redirect
  • vuepress-plugin-smooth-scroll
  • vuepress-plugin-table-of-contents
  • vuepress-plugin-typescript
  • vuepress-plugin-zooming
  • vuepress-mergeable
  • vuepress-types

What kind of change does this PR introduce? (check at least one)

  • [ x ] Bugfix (fix)
  • Feature (feat)
  • Performance enhancement (perf)
  • Code Style (style)
  • Refactor (refactor)
  • Docs (docs)
  • Build-related changes (build)
  • CI-related changes (ci)
  • Testing (test)
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • [ x ] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

Other information:

the old code `mathjax: {` gives me a lint error
@franklinqin0
Copy link
Contributor Author

Actually on a second thought, could have the example similar to packages/docs/src/.vuepress/config.js#L52

The originally code lacks a quote anyway

@franklinqin0
Copy link
Contributor Author

Also, should fix the Chinese doc as well: packages/docs/src/zh/plugins/mathjax.md#L149

@meteorlxy meteorlxy added documentation Improvements or additions to documentation plugin:mathjax labels Jan 30, 2020
Copy link
Contributor Author

@franklinqin0 franklinqin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished the both the English and Chinese doc fixes.

@meteorlxy meteorlxy changed the title fix the macros code error docs(plugin-mathjax): update macros code demo Feb 1, 2020
@meteorlxy meteorlxy merged commit 6936d57 into vuepress:master Feb 1, 2020
@meteorlxy
Copy link
Member

Thanks for your contribution ❤️

@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation plugin:mathjax
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants