Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stripe payment element support #257

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mdavo6
Copy link
Contributor

@mdavo6 mdavo6 commented Aug 18, 2022

Description

  • Adds support for stripe payment element (previous implementation used card element) - see comparison: https://stripe.com/docs/payments/payment-card-element-comparison.
  • Order no longer proceeds to complete when payment fails.
  • Adds support for error message from payment element when payment fails.
  • Adds two new API clients to support new functionality - addPaymentMethod and getPaymentIntent.

Related Issue

#256

Motivation and Context

See description in #256
In short, the Stripe payment element offers 18+ payment methods OOB vs the current implementation which offers card payment only.

How Has This Been Tested?

Tested on chrome. Note: PR will require corresponding spree_gateway PR to work spree/spree_gateway#409.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mdavo6
Copy link
Contributor Author

mdavo6 commented Aug 23, 2022

Thanks for the review @letelete . I have updated to address your feedback if you would like to take another look 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants