fix: prepend hostname to image urls only when it's not preset #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpdrozd
force-pushed
the
fix/product-image-host
branch
from
e45ca89 to
a7f472b
Compare
fpdrozd
changed the title
fpdrozd
force-pushed
the
fix/product-image-host
branch
from
87a8bb1 to
2bb9363
Compare
rafalcymerys
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the addHostToImage function from the api serializers and all of the places it has been referenced.
Description
Before a product image url coming from Spree didn't include the host. Right now it returns a full url so it's not needed to prefix the host.
Images weren't showing because the final url was invalid.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: