Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: making the repository in the standard #3

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

bloodf
Copy link
Member

@bloodf bloodf commented Mar 31, 2022

Description

Added community standard in the repository

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.

Changelog

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

  • I have written test cases for my code
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I tested manually my code, and it works well with both:

  • Default Theme
  • Capybara Theme

Code standards

  • My code follows the code style of this project.

Docs

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@bloodf bloodf marked this pull request as ready for review March 31, 2022 19:51
@Ikkevoid
Copy link
Member

Ikkevoid commented May 24, 2022

There are also wrong imports in some of the composables files.

@bloodf
Copy link
Member Author

bloodf commented Jun 6, 2022

There are also wrong imports in some of the composables files.

This PR is old, was created for you guys to merge back then, and start making it on top of our standards. I would recommend you guys update the PR with the necessary changes, or propose here withing GitHub as a proposed commit change :) so we can merge and make the repo closer to our standards :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants