Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Update newsletter subscription preference doesn't work #159

Closed
1 task done
jonathanribas opened this issue Aug 20, 2021 · 1 comment · Fixed by #170 or #192
Closed
1 task done

[Bug]: Update newsletter subscription preference doesn't work #159

jonathanribas opened this issue Aug 20, 2021 · 1 comment · Fixed by #170 or #192
Assignees
Labels
backlog bug Something isn't working good first issue Good for newcomers

Comments

@jonathanribas
Copy link
Contributor

jonathanribas commented Aug 20, 2021

Expected Behavior

Update my newsletter subscription should work.

Actual Behavior

I can't update my newsletter subscription option:

It's actually calling /api/magento/updateCustomerEmail endpoint posting [{}] 0: {}

{"graphQLErrors":[{"message":"Variable \"$email\" of required type \"String!\" was not provided.\n\nVariable \"$password\" of required type \"String!\" was not provided.","extensions":{"category":"graphql"}}],"networkError":null,"message":"GraphQL error: Variable \"$email\" of required type \"String!\" was not provided.\n\nVariable \"$password\" of required type \"String!\" was not provided."}

Possible Solution

No response

Steps to reproduce

  • Login to your account
  • Go to your Account / Newsletter
  • Update you preference
  • You have an error in your Dev Tools console

What version of Magento 2 integration are you using?

Adobe Commerce 2.4.3 / VSF 1.0.0-rc.2

What version of Node.js are you using?

v14.17.5

What browser (and version) are you using?

Chrome 92.0.4515.159 (Official Build) (x86_64)

What operating system (and version) are you using?

Mac OSX

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jonathanribas jonathanribas added bug Something isn't working triage-needed Issues that need to be checked labels Aug 20, 2021
@jonathanribas jonathanribas changed the title [Bug]: [Bug]: Update newsletter subscription preference doesn't work Aug 20, 2021
@bloodf bloodf added good first issue Good for newcomers and removed triage-needed Issues that need to be checked labels Aug 23, 2021
@bloodf bloodf added the backlog label Aug 31, 2021
@zfmaster zfmaster self-assigned this Sep 3, 2021
@bloodf bloodf self-assigned this Sep 4, 2021
bloodf added a commit that referenced this issue Sep 4, 2021
* fix(theme): does not display add to wishlist when not user not authenticated

* fix(theme): add zoom to gallery

* chore: fixed the gitflow GitHub action

* refactor(api-client): updated the requestPasswordResetEmail to add customQuery

* feat(api-client): add the resetPassword method

* feat(composables): add the useForgotPasswordFactory

* refactor(composables): add initial logic for resetting the password

* refactor(api-client): fixed customQuery implementation

* refactor(composables): fixed Magento method application

* refactor(composables): applied forgotPasswordGetters.ts rules for isPasswordChanged

* feat(theme): created page for resetting user password

* fix(composables): fixed useUser not being correctly updated

fixes #159

* fix(theme): add Ui notification on user data update

fixes #161
fixes #160

* fix(theme): fixed onSSR to onBeforeMount
@bloodf bloodf linked a pull request Sep 4, 2021 that will close this issue
9 tasks
@bloodf
Copy link
Contributor

bloodf commented Sep 4, 2021

Fixed on PR #170

@bloodf bloodf closed this as completed Sep 4, 2021
bloodf added a commit that referenced this issue Oct 5, 2021
* fix: fixed user password reset and resolved other minor issues (#170)

* fix(theme): does not display add to wishlist when not user not authenticated

* fix(theme): add zoom to gallery

* chore: fixed the gitflow GitHub action

* refactor(api-client): updated the requestPasswordResetEmail to add customQuery

* feat(api-client): add the resetPassword method

* feat(composables): add the useForgotPasswordFactory

* refactor(composables): add initial logic for resetting the password

* refactor(api-client): fixed customQuery implementation

* refactor(composables): fixed Magento method application

* refactor(composables): applied forgotPasswordGetters.ts rules for isPasswordChanged

* feat(theme): created page for resetting user password

* fix(composables): fixed useUser not being correctly updated

fixes #159

* fix(theme): add Ui notification on user data update

fixes #161
fixes #160

* fix(theme): fixed onSSR to onBeforeMount

* fix: add shipping provider to basket (#171)

* fix: set shipping provider to cart

* fix: query full cart from M2

* fix: remove console log

* fix: set cart id for logged in customer (#172)

* fix(theme): fixed Product display and search result display (#175)

* fix(theme): fixed wishlist icon appearing in search result

fixes #173

* fix(theme): fixed not showing loader in Product.vue page

* fix(theme): fixed not showing loader in Product.vue page

* fix(theme): separated GroupedProduct as a component

fixes #174

* fix(theme): added canAddToCart prop to BundleProductSelector.vue

* fix(composables): fixed name as undefined

* fix(composables): fixed name as undefined

* docs: update base information in docs (#176)

* docs: added api-extraction

* docs: fixed api-extraction

* docs: fixed api-extraction

* docs: updated about page

* docs: fixed docs building

* refactor(api-client): updated graphql queries

* refactor(theme): add PM2 for server control

* refactor: updated dependencies and fixed theme bugs (#178)

* chore(eslint): updated dependencies

- updated **eslint-plugin-unicorn** to **36.0.0**

* chore(eslint-import): updated dependencies

- updated **eslint-import-resolver-typescript** to **2.5.0**
- updated **eslint-plugin-import** to **2.24.2**

* chore(eslint-typescript): updated dependencies

- updated **@typescript-eslint/eslint-plugin** to **4.31.1**
- updated **@typescript-eslint/parser** to **4.31.1**

* chore(eslint-vue): updated dependencies

- updated **eslint-plugin-vue** to **7.17.0**

* chore(api-client): updated dependencies

- updated **@apollo/client** to **3.4.11**
- updated **graphql** to **15.5.3**
- updated **graphql-tools** to **8.2.0**
- updated **node-fetch** to **3.0.0**
- updated **typescript** to **4.4.3**

* chore(theme): updated dependencies

- updated **core-js** to **3.17.3**
- updated **vee-validate** to **3.4.13**
- updated **babel-jest** to **27.2.0**
- updated **cypress** to **8.4.0**
- updated **jest** to **27.2.0**
- updated **npm-check-updates** to **11.8.5**
- updated **typescript** to **4.4.3**

* chore: updated dependencies

- updated **@babel/core** to **7.15.5**
- updated **@graphql-codegen/cli** to **2.2.0**
- updated **@graphql-codegen/typescript** to **2.2.2**
- updated **@graphql-codegen/typescript-operations** to **2.1.4**
- updated **@types/node** to **16.9.2**
- updated **@typescript-eslint/parser** to **4.31.1**
- updated **husky** to **7.0.2**
- updated **jest** to **27.2.0**
- updated **npm-check-updates** to **11.8.5**
- updated **vue-eslint-parser** to **7.11.0**

* feat(theme): add new environment variables and configuration

* refactor(theme): fixed missing composables state

* feat(theme): added wishlist control on bottom menu

* docs: updated docs for how to create new store

* chore: update docs-deployment.yaml

* chore: update docs-deployment.yaml

* refactor(theme): updated theme Core Web Vitals

* docs: update documentation deployment

* docs: update documentation deployment

* refactor(theme): fixed performance build

* docs: fixed Dockerfile image

* docs: updated Dockerfile to node 14

* docs: added yarn to the Dockerfile

* docs: update Dockerfile build command

* docs: add new nuxt tips and tricks to documentation

* feat!: new changes to GraphQL and `theme` components (#180)

* chore: updated dependencies and devDependencies

- updated **@rollup/plugin-node-resolve** to **13.0.5**
- updated **@types/node** to **16.9.6**
- updated **@typescript-eslint/parser** to **4.31.2**
- updated **jest** to **27.2.1**
- updated **jest-localstorage-mock** to **2.4.18**
- updated **rollup** to **2.57.0**

* chore(eslint-jest): updated dependencies and devDependencies

- updated **eslint-plugin-jest** to **24.4.2**

* chore(eslint-typescript): updated dependencies and devDependencies

- updated  **@typescript-eslint/eslint-plugin** to **4.31.2**
- updated **@typescript-eslint/parser** to **4.31.2**

* chore(eslint-vue): updated dependencies and devDependencies

- updated  **eslint-plugin-vue** to **7.18.0**

* chore(api-client): updated dependencies and devDependencies

- updated **@apollo/client** to **3.4.13**
- updated **@vue-storefront/core** to **2.4.2**
- updated **graphql** to **15.6.0**

* chore(composables): updated dependencies and devDependencies

- updated @vue-storefront/core** to **2.4.2**
- updated jsdom** to **17.0.0**
- updated jsdom-global** to **3.0.2**
- updated vue-template-compiler** to **2.6.x**

* chore(theme): updated dependencies and devDependencies

- updated **@vue-storefront/core** to **2.4.2**
- updated **@vue-storefront/middleware** to **2.4.2**
- updated **@vue-storefront/nuxt** to **2.4.2**
- updated **@vue-storefront/nuxt-theme** to **2.4.2**
- updated **core-js** to **3.18.0**
- updated **pm2** to **5.1.2**
- updated **babel-jest** to **27.2.1**
- updated **cypress** to **8.4.1**
- updated **jest** to **27.2.1**
- updated **jest-localstorage-mock** to **2.4.18**

* refactor(composables): moved getters to root folder

* refactor(theme): removed TS typing from Page.vue

* refactor!(api-client): removed fragments and applied single queries / mutations

- all the fragments needed to be removed due to Magento GraphQL server does not support it and causing problematic errors, reporting `null` and `undefined` values, because it wont recognize the fragment.
- Added single queries / mutations with higher complexity, requiring a change in the Magento configuration or the usage of custom Caravel module to configure the GraphQL server

BREAKING CHANGE: removal of the fragments, require changes in the Magento server

* feat(composables): created the useUpsellProducts composable

* feat(composables): created the useRelatedProducts composable

* refactor(composables): removed the multiple queries search from useProduct composable

* chore(composables): fixed file imports in the getters and exports in index.ts

* feat(theme): created the RelatedProducts.vue component

* feat(theme): created the UpsellProducts.vue component

* chore: fixed yarn.lock file

* refactor(theme): fixed PostCSS calc

* refactor(composables): added base test files

* refactor(composables): added missing loggers

* refactor(composables): extracted generators

* refactor(theme): removed lang="ts"

* refactor(composables): updated logger result

* feat(theme): created CategorySidebarMenu.vue component

* refactor(composables): updated getters

* chore(api-client): updated API schema

* feat(theme): created useRoute composable

* doc: added information about the Magento GraphQL module

* feat: added `useCustomQuery` & `useCustomMutation` (#183)

* feat(api-client): created `customQuery` api method

* feat(api-client): created `customMutation` api method

* feat(api-client): exported `customQuery` & `customMutation` api methods

* feat(composables): created `useCustomMutation` composable

* feat(composables): created `useCustomQuery` composable

* feat(composables): added `useCustomQuery` & `useCustomMutation` types

* docs: updated api-reference

* docs: added docs for `useCustomQuery`

* refactor(composables): fixed `useCustomQuery` & `useCustomMutation` factories

* refactor(composables): fixed composables exporters

* refactor(composables): fixed `useCustomQuery` & `useCustomMutation` loggers

* refactor(composables): fixed api-extractor-data exporter

* chore: updated README.md

* docs: added base composables docs

* docs: added composables docs to config.js

* docs: added demo link

* fix(theme): load addresses on remove (#189)

* refactor(composables): update `load` method of `useCart` composable (#182)

* refactor(composables): do not create empty cart on M2 side, clean up load method

* refactor(composables): overwrite useCartFactory for new param

* chore: updated README.md

* docs: updated honorable mentions

* chore: remove gitflow action

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Bogdan Podlesnii <bogdan.podlesnii@gmail.com>
bloodf added a commit that referenced this issue Oct 5, 2021
* fix: fixed user password reset and resolved other minor issues (#170)

* fix(theme): does not display add to wishlist when not user not authenticated

* fix(theme): add zoom to gallery

* chore: fixed the gitflow GitHub action

* refactor(api-client): updated the requestPasswordResetEmail to add customQuery

* feat(api-client): add the resetPassword method

* feat(composables): add the useForgotPasswordFactory

* refactor(composables): add initial logic for resetting the password

* refactor(api-client): fixed customQuery implementation

* refactor(composables): fixed Magento method application

* refactor(composables): applied forgotPasswordGetters.ts rules for isPasswordChanged

* feat(theme): created page for resetting user password

* fix(composables): fixed useUser not being correctly updated

fixes #159

* fix(theme): add Ui notification on user data update

fixes #161
fixes #160

* fix(theme): fixed onSSR to onBeforeMount

* fix: add shipping provider to basket (#171)

* fix: set shipping provider to cart

* fix: query full cart from M2

* fix: remove console log

* fix: set cart id for logged in customer (#172)

* fix(theme): fixed Product display and search result display (#175)

* fix(theme): fixed wishlist icon appearing in search result

fixes #173

* fix(theme): fixed not showing loader in Product.vue page

* fix(theme): fixed not showing loader in Product.vue page

* fix(theme): separated GroupedProduct as a component

fixes #174

* fix(theme): added canAddToCart prop to BundleProductSelector.vue

* fix(composables): fixed name as undefined

* fix(composables): fixed name as undefined

* docs: update base information in docs (#176)

* docs: added api-extraction

* docs: fixed api-extraction

* docs: fixed api-extraction

* docs: updated about page

* docs: fixed docs building

* refactor(api-client): updated graphql queries

* refactor(theme): add PM2 for server control

* refactor: updated dependencies and fixed theme bugs (#178)

* chore(eslint): updated dependencies

- updated **eslint-plugin-unicorn** to **36.0.0**

* chore(eslint-import): updated dependencies

- updated **eslint-import-resolver-typescript** to **2.5.0**
- updated **eslint-plugin-import** to **2.24.2**

* chore(eslint-typescript): updated dependencies

- updated **@typescript-eslint/eslint-plugin** to **4.31.1**
- updated **@typescript-eslint/parser** to **4.31.1**

* chore(eslint-vue): updated dependencies

- updated **eslint-plugin-vue** to **7.17.0**

* chore(api-client): updated dependencies

- updated **@apollo/client** to **3.4.11**
- updated **graphql** to **15.5.3**
- updated **graphql-tools** to **8.2.0**
- updated **node-fetch** to **3.0.0**
- updated **typescript** to **4.4.3**

* chore(theme): updated dependencies

- updated **core-js** to **3.17.3**
- updated **vee-validate** to **3.4.13**
- updated **babel-jest** to **27.2.0**
- updated **cypress** to **8.4.0**
- updated **jest** to **27.2.0**
- updated **npm-check-updates** to **11.8.5**
- updated **typescript** to **4.4.3**

* chore: updated dependencies

- updated **@babel/core** to **7.15.5**
- updated **@graphql-codegen/cli** to **2.2.0**
- updated **@graphql-codegen/typescript** to **2.2.2**
- updated **@graphql-codegen/typescript-operations** to **2.1.4**
- updated **@types/node** to **16.9.2**
- updated **@typescript-eslint/parser** to **4.31.1**
- updated **husky** to **7.0.2**
- updated **jest** to **27.2.0**
- updated **npm-check-updates** to **11.8.5**
- updated **vue-eslint-parser** to **7.11.0**

* feat(theme): add new environment variables and configuration

* refactor(theme): fixed missing composables state

* feat(theme): added wishlist control on bottom menu

* docs: updated docs for how to create new store

* chore: update docs-deployment.yaml

* chore: update docs-deployment.yaml

* refactor(theme): updated theme Core Web Vitals

* docs: update documentation deployment

* docs: update documentation deployment

* refactor(theme): fixed performance build

* docs: fixed Dockerfile image

* docs: updated Dockerfile to node 14

* docs: added yarn to the Dockerfile

* docs: update Dockerfile build command

* docs: add new nuxt tips and tricks to documentation

* feat!: new changes to GraphQL and `theme` components (#180)

* chore: updated dependencies and devDependencies

- updated **@rollup/plugin-node-resolve** to **13.0.5**
- updated **@types/node** to **16.9.6**
- updated **@typescript-eslint/parser** to **4.31.2**
- updated **jest** to **27.2.1**
- updated **jest-localstorage-mock** to **2.4.18**
- updated **rollup** to **2.57.0**

* chore(eslint-jest): updated dependencies and devDependencies

- updated **eslint-plugin-jest** to **24.4.2**

* chore(eslint-typescript): updated dependencies and devDependencies

- updated  **@typescript-eslint/eslint-plugin** to **4.31.2**
- updated **@typescript-eslint/parser** to **4.31.2**

* chore(eslint-vue): updated dependencies and devDependencies

- updated  **eslint-plugin-vue** to **7.18.0**

* chore(api-client): updated dependencies and devDependencies

- updated **@apollo/client** to **3.4.13**
- updated **@vue-storefront/core** to **2.4.2**
- updated **graphql** to **15.6.0**

* chore(composables): updated dependencies and devDependencies

- updated @vue-storefront/core** to **2.4.2**
- updated jsdom** to **17.0.0**
- updated jsdom-global** to **3.0.2**
- updated vue-template-compiler** to **2.6.x**

* chore(theme): updated dependencies and devDependencies

- updated **@vue-storefront/core** to **2.4.2**
- updated **@vue-storefront/middleware** to **2.4.2**
- updated **@vue-storefront/nuxt** to **2.4.2**
- updated **@vue-storefront/nuxt-theme** to **2.4.2**
- updated **core-js** to **3.18.0**
- updated **pm2** to **5.1.2**
- updated **babel-jest** to **27.2.1**
- updated **cypress** to **8.4.1**
- updated **jest** to **27.2.1**
- updated **jest-localstorage-mock** to **2.4.18**

* refactor(composables): moved getters to root folder

* refactor(theme): removed TS typing from Page.vue

* refactor!(api-client): removed fragments and applied single queries / mutations

- all the fragments needed to be removed due to Magento GraphQL server does not support it and causing problematic errors, reporting `null` and `undefined` values, because it wont recognize the fragment.
- Added single queries / mutations with higher complexity, requiring a change in the Magento configuration or the usage of custom Caravel module to configure the GraphQL server

BREAKING CHANGE: removal of the fragments, require changes in the Magento server

* feat(composables): created the useUpsellProducts composable

* feat(composables): created the useRelatedProducts composable

* refactor(composables): removed the multiple queries search from useProduct composable

* chore(composables): fixed file imports in the getters and exports in index.ts

* feat(theme): created the RelatedProducts.vue component

* feat(theme): created the UpsellProducts.vue component

* chore: fixed yarn.lock file

* refactor(theme): fixed PostCSS calc

* refactor(composables): added base test files

* refactor(composables): added missing loggers

* refactor(composables): extracted generators

* refactor(theme): removed lang="ts"

* refactor(composables): updated logger result

* feat(theme): created CategorySidebarMenu.vue component

* refactor(composables): updated getters

* chore(api-client): updated API schema

* feat(theme): created useRoute composable

* doc: added information about the Magento GraphQL module

* feat: added `useCustomQuery` & `useCustomMutation` (#183)

* feat(api-client): created `customQuery` api method

* feat(api-client): created `customMutation` api method

* feat(api-client): exported `customQuery` & `customMutation` api methods

* feat(composables): created `useCustomMutation` composable

* feat(composables): created `useCustomQuery` composable

* feat(composables): added `useCustomQuery` & `useCustomMutation` types

* docs: updated api-reference

* docs: added docs for `useCustomQuery`

* refactor(composables): fixed `useCustomQuery` & `useCustomMutation` factories

* refactor(composables): fixed composables exporters

* refactor(composables): fixed `useCustomQuery` & `useCustomMutation` loggers

* refactor(composables): fixed api-extractor-data exporter

* chore: updated README.md

* docs: added base composables docs

* docs: added composables docs to config.js

* docs: added demo link

* fix(theme): load addresses on remove (#189)

* refactor(composables): update `load` method of `useCart` composable (#182)

* refactor(composables): do not create empty cart on M2 side, clean up load method

* refactor(composables): overwrite useCartFactory for new param

* chore: updated README.md

* docs: updated honorable mentions

* chore: updated README.md

* chore: updated README.md

* chore: updated README.md

* chore: fixed versioning

* refactor(api-client): fixed API exports

* refactor(composables): fixed composables types

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Bogdan Podlesnii <bogdan.podlesnii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog bug Something isn't working good first issue Good for newcomers
Projects
None yet
3 participants