Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add TSDocs focused on SDK usage and deprecate magentoModule #1519

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

WojtekTheWebDev
Copy link
Collaborator

@WojtekTheWebDev WojtekTheWebDev commented Apr 16, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

add TSDocs focused on SDK usage and deprecate magentoModule

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@WojtekTheWebDev WojtekTheWebDev requested a review from a team as a code owner April 16, 2024 14:03
Copy link

changeset-bot bot commented Apr 16, 2024

πŸ¦‹ Changeset detected

Latest commit: 38b3582

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vue-storefront/magento-sdk Patch
@vue-storefront/magento-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@WojtekTheWebDev WojtekTheWebDev changed the title refactor: add TSDocs focused on SDK usage refactor: add TSDocs focused on SDK usage and deprecate magentoModule Apr 17, 2024
sethidden
sethidden previously approved these changes Apr 18, 2024
…1520)

* docs: document usage of middlewareModule with Magento 2 integration

* Update docs/content/2.getting-started/3.supported-features.md

Co-authored-by: Matt Maribojoc <matthewmaribojoc@gmail.com>

---------

Co-authored-by: Matt Maribojoc <matthewmaribojoc@gmail.com>
@WojtekTheWebDev WojtekTheWebDev merged commit 6672edf into main Apr 19, 2024
8 checks passed
@WojtekTheWebDev WojtekTheWebDev deleted the refactor/migration-to-middlewareModule branch April 19, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants