fix: promotion code handling (#1522)

vuestorefront · Jun 1, 2021 · acaefeb · acaefeb · vercel · Jun 1, 2021
1 parent 7d3c317
commit acaefeb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/composables/src/hooks/useCart/index.ts b/packages/composables/src/hooks/useCart/index.ts
@@ -130,7 +130,7 @@ export const useCart = (rootContext: ApplicationVueContext): IUseCart => {
  async function submitPromotionCode(promotionCode: string) {
  if (promotionCode) {
  const result = await addPromotionCode(promotionCode, apiInstance);
- ``;
+ broadcastUpcomingErrors(result);
  _storeCart.value = result;
  broadcast(INTERCEPTOR_KEYS.ADD_PROMOTION_CODE, {
  result,

diff --git a/packages/default-theme/src/logic/notifications/index.js b/packages/default-theme/src/logic/notifications/index.js
@@ -25,13 +25,15 @@ export const addToCartNotification = (payload, rootContext) => {
 
 export const addPromotionCodeNotification = (payload, rootContext) => {
  const { pushSuccess, pushError } = useNotifications(rootContext)
- const { result } = payload
+ const { result, promotionCode } = payload
 
- if (!result.errors || !result.errors.length) {
+ if (!result.errors || !Object.keys(result.errors).length) {
  return pushSuccess(rootContext.$t("Promotion code added successfully"))
  }
 
- const err = Object.values(result.errors)[0]
+ const err = Object.values(result.errors).find(
+ (error) => promotionCode === error.promotionCode
+ )
  if (err) {
  switch (err.messageKey) {
  case "promotion-not-found":