Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(listing): useListing composable with criteria refactor #1086

Merged
merged 29 commits into from
Oct 5, 2020

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Sep 11, 2020

Changes

Pretty big refactoring of listings and products searching. Listing interfaces are now much simpler and consistent.

closes #1071
closes #1079 - method loadMore in useListing composable
closes #1075 - you can add this to defaults now
closes #1072
closes #1061
closes #1054

Checklist

@vercel
Copy link

vercel bot commented Sep 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/1tg9xijo9
✅ Preview: https://shopware-pwa-docs-git-feat-listing-refactor.shopware-pwa.vercel.app

@vercel vercel bot temporarily deployed to preview September 11, 2020 12:36 Inactive
@vercel vercel bot temporarily deployed to preview September 14, 2020 07:31 Inactive
@vercel vercel bot temporarily deployed to preview September 14, 2020 07:35 Inactive
@vercel vercel bot temporarily deployed to preview September 14, 2020 11:02 Inactive
@vercel vercel bot temporarily deployed to preview September 16, 2020 09:43 Inactive
@vercel vercel bot temporarily deployed to preview September 23, 2020 07:53 Inactive
@vercel vercel bot temporarily deployed to preview September 25, 2020 21:32 Inactive
@mkucmus mkucmus added this to the v0.5.0 milestone Sep 28, 2020
@vercel vercel bot temporarily deployed to preview October 3, 2020 16:06 Inactive
@vercel vercel bot temporarily deployed to preview October 5, 2020 08:57 Inactive
@vercel vercel bot temporarily deployed to preview October 5, 2020 09:54 Inactive
@github-actions
Copy link

github-actions bot commented Oct 5, 2020

💙 shopware-pwa-canary successfully deployed at https://6fad488984dee0d7518fad78c782847d01be50d7.shopware-pwa-canary.preview.storefrontcloud.io

@patzick patzick marked this pull request as ready for review October 5, 2020 10:13
Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the biggest improvement / refactor so far 🚀

@vercel vercel bot temporarily deployed to preview October 5, 2020 10:48 Inactive
@mkucmus mkucmus changed the title refactor(listing): useListing composable with criteria refactor draft refactor(listing): useListing composable with criteria refactor Oct 5, 2020
@vercel vercel bot temporarily deployed to preview October 5, 2020 10:57 Inactive
@mkucmus mkucmus merged commit 0e40878 into master Oct 5, 2020
@mkucmus mkucmus deleted the feat-listing-refactor branch October 5, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment