Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default-theme): remove apartment number from forms #1315

Merged
merged 1 commit into from
Jan 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/default-theme/src/components/SwAddress.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<h4 class="sw-address__title">{{ addressTitle }}</h4>
<slot name="before-content" />
<p class="content">
{{ street }} {{ apartment }}, {{ zipcode }}<br />
{{ street }}, {{ zipcode }}<br />
{{ city }}
</p>
<p v-if="phoneNumber" class="content">
Expand Down Expand Up @@ -43,9 +43,6 @@ export default {
city() {
return this.address.city
},
apartment() {
return this.address.apartment
},
phoneNumber() {
return this.address.phoneNumber
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,28 +29,18 @@
class="sw-form__input"
required
/>
</div>
<div class="inputs-group">
<SwInput
v-model="street"
:valid="!validations.street.$error"
:error-message="$t('This field is required')"
:label="$t('Street')"
:label="$t('Street and house number')"
data-cy="street-name"
name="street"
class="sw-form__input"
required
/>
</div>
<div class="inputs-group">
<SwInput
v-model="apartment"
:valid="!validations.apartment.$error"
:error-message="$t('This field is required')"
:label="$t('House/Apartment number')"
data-cy="apartment"
name="apartment"
class="sw-form__input"
required
/>
<SwInput
v-model="city"
:valid="!validations.city.$error"
Expand Down Expand Up @@ -142,7 +132,6 @@ export default {
firstName,
lastName,
street,
apartment,
city,
state,
zipcode,
Expand All @@ -163,7 +152,6 @@ export default {
firstName,
lastName,
street,
apartment,
city,
state,
zipcode,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,28 +21,18 @@
class="sw-form__input"
required
/>
</div>
<div class="inputs-group">
<SwInput
v-model="street"
:valid="!validations.street.$error"
:error-message="$t('This field is required')"
:label="$t('Street')"
:label="$t('Street and house number')"
data-cy="street-name"
name="street"
class="sw-form__input"
required
/>
</div>
<div class="inputs-group">
<SwInput
v-model="apartment"
:valid="!validations.apartment.$error"
:error-message="$t('This field is required')"
:label="$t('House/Apartment number')"
data-cy="apartment"
name="apartment"
class="sw-form__input"
required
/>
<SwInput
v-model="city"
:valid="!validations.city.$error"
Expand Down Expand Up @@ -137,7 +127,6 @@ export default {
firstName,
lastName,
street,
apartment,
city,
state,
zipcode,
Expand Down Expand Up @@ -167,7 +156,6 @@ export default {
firstName,
lastName,
street,
apartment,
city,
state,
zipcode,
Expand Down
20 changes: 2 additions & 18 deletions packages/default-theme/src/components/forms/SwAddressForm.vue
Original file line number Diff line number Diff line change
Expand Up @@ -53,24 +53,15 @@
<SwInput
v-model="form.street"
name="street"
:label="$t('Street')"
:label="$t('Street and house number')"
:error-message="$t('Street is required')"
:valid="!$v.form.street.$error"
required
class="sw-form__input"
@blur="$v.form.street.$touch()"
/>
</div>
<SwInput
v-model="form.apartment"
name="apartment"
:label="$t('House/Apartment number')"
:error-message="$t('Apartment is required')"
:valid="!$v.form.apartment.$error"
required
class="form__element"
@blur="$v.form.apartment.$touch()"
/>

<div class="inputs-group">
<SwInput
v-model="form.city"
Expand All @@ -89,7 +80,6 @@
:label="$t('State/Province')"
:error-message="$t('State is required')"
:valid="!$v.form.state.$error"
required
class="sw-form__input"
:required="forceState"
@blur="$v.form.state.$touch()"
Expand Down Expand Up @@ -178,7 +168,6 @@ export default {
country: null,
zipcode: "",
street: "",
apartment: "",
city: "",
phoneNumber: "",
}),
Expand Down Expand Up @@ -234,7 +223,6 @@ export default {
salutation,
zipcode,
street,
apartment,
city,
country,
phoneNumber,
Expand All @@ -247,7 +235,6 @@ export default {
salutationId: salutation.id,
zipcode,
street,
apartment,
city,
countryId: country.id,
phoneNumber,
Expand Down Expand Up @@ -281,9 +268,6 @@ export default {
street: {
required,
},
apartment: {
required,
},
city: {
required,
},
Expand Down
6 changes: 0 additions & 6 deletions packages/default-theme/src/logic/checkout/usePaymentStep.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export const usePaymentStep = createCheckoutStep({
firstName: null,
lastName: null,
street: null,
apartment: null,
city: null,
state: null,
zipcode: null,
Expand Down Expand Up @@ -41,11 +40,6 @@ export const usePaymentStepValidationRules = {
return instance.differentThanShipping
}),
},
apartment: {
required: requiredIf(function (instance) {
return instance.differentThanShipping
}),
},
city: {
required: requiredIf(function (instance) {
return instance.differentThanShipping
Expand Down
4 changes: 0 additions & 4 deletions packages/default-theme/src/logic/checkout/useShippingStep.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ export const useShippingStep = createCheckoutStep({
firstName: null,
lastName: null,
street: null,
apartment: null,
city: null,
state: null,
zipcode: null,
Expand Down Expand Up @@ -39,9 +38,6 @@ export const useShippingStepValidationRules = {
street: {
required,
},
apartment: {
required,
},
city: {
required,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { usePaymentStep } from "@/logic/checkout/usePaymentStep"
import { PAGE_ORDER_SUCCESS } from "@/helpers/pages"

export const useUICheckoutPage = (rootContext) => {
const { router, i18n } = getApplicationContext(
const { router, routing } = getApplicationContext(
rootContext,
"useUICheckoutPage"
)
Expand Down Expand Up @@ -87,7 +87,7 @@ export const useUICheckoutPage = (rootContext) => {
nextStepNumber > CHECKOUT_STEPS.REVIEW
) {
const order = await createOrder()
router.push(i18n.path(`${PAGE_ORDER_SUCCESS}?orderId=${order.id}`))
router.push(routing.getUrl(`${PAGE_ORDER_SUCCESS}?orderId=${order.id}`))
} else {
const nextStep = getStepByNumber(nextStepNumber)
if (stepsStatus.value[nextStep].available) {
Expand Down