Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composables): product available stock information #1551

Conversation

meeshoogendoorn
Copy link
Contributor

@meeshoogendoorn meeshoogendoorn commented Jun 15, 2021

Changes

Closes #1539

Checklist

@vercel
Copy link

vercel bot commented Jun 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/4g3krTjHZcGK5c5j98s2vu54pisN
✅ Preview: https://shopware-pwa-docs-git-fork-meeshoogendoorn-9cc400-shopware-pwa.vercel.app

@vercel vercel bot temporarily deployed to preview June 15, 2021 07:06 Inactive
@vercel vercel bot temporarily deployed to preview June 15, 2021 08:39 Inactive
@meeshoogendoorn
Copy link
Contributor Author

@mkucmus I added the computed to the useAddToCart Composable. I runned yarn lint before pushing with the command yarn lint from the project but he forrmatted some more files. is that okey? I can't find any prettierrc file in the project also?

@vercel vercel bot temporarily deployed to preview June 15, 2021 12:26 Inactive
@vercel vercel bot temporarily deployed to preview June 15, 2021 12:30 Inactive
@vercel vercel bot temporarily deployed to preview June 15, 2021 12:36 Inactive
@patzick
Copy link
Collaborator

patzick commented Jun 15, 2021

Thanks, @meeshoogendoorn, great to see your contribution! 💪

It's okay to run yarn lint, there is a rule linting all files before commit, but the linter wasn't running on all files in a long time. I cleared it on the master branch to see real changes in here.
Created check-in #1553 to see if GH actions are passing. The one with composables is failing, as you haven't refreshed API docs.

Please run yarn build -t locally and commit markdown changes that will be automatically created :)

Overall all looks great, so I'll merge that right after fixing CI!

@vercel vercel bot temporarily deployed to preview June 15, 2021 13:10 Inactive
@vercel vercel bot temporarily deployed to preview June 15, 2021 13:13 Inactive
@vercel vercel bot temporarily deployed to preview June 16, 2021 13:33 Inactive
… of github.com:meeshoogendoorn/shopware-pwa into fix/product-customFields-availableStock-includes-param
@vercel vercel bot temporarily deployed to preview June 16, 2021 13:40 Inactive
@meeshoogendoorn
Copy link
Contributor Author

@patzick It's fixed 👍

@vercel vercel bot temporarily deployed to preview June 16, 2021 13:46 Inactive
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌 thank you for your contribution! We're waiting for the next ones 🚀

@patzick patzick changed the title Fix/product custom fields available stock includes param fix(composables): product available stock information Jun 16, 2021
@patzick patzick merged commit 5c64d35 into vuestorefront:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CustomFields are moved
3 participants