Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(default-theme): rename incorrect newsletter form element #1710

Merged
merged 1 commit into from
Oct 19, 2021
Merged

fix(default-theme): rename incorrect newsletter form element #1710

merged 1 commit into from
Oct 19, 2021

Conversation

adam-paterson
Copy link
Contributor

@adam-paterson adam-paterson commented Oct 17, 2021 •
edited
Loading

Changes

  • Renames CmsElementNesletterForm to CmsElementNewsletterForm
  • Corrects reference to CmsElementNesletterForm in CmsElementForm

Checklist

@vercel
Copy link

vercel bot commented Oct 17, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/CoJiCVbRFGajo44qFxqFErV8QasA
✅ Preview: Canceled

[Deployment for 9a4eb0b canceled]

@adam-paterson adam-paterson force-pushed the fix/default-theme/incorrect-newsletter-component-filename branch from 781eb8e to 33ae7b8 Compare October 18, 2021 16:00
@adam-paterson adam-paterson force-pushed the fix/default-theme/incorrect-newsletter-component-filename branch from 33ae7b8 to 9a4eb0b Compare October 18, 2021 16:01
patzick
patzick approved these changes Oct 19, 2021
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 thank you for your contribution!

@patzick patzick merged commit a65f075 into vuestorefront:master Oct 19, 2021
@adam-paterson adam-paterson deleted the fix/default-theme/incorrect-newsletter-component-filename branch October 19, 2021 07:40
@adam-paterson
Copy link
Contributor Author

@patzick No problem, not much but it took me at least 20mins to figure out why the name wasn't resolving when it existed. Always a missing character.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patzick patzick patzick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-paterson @patzick