Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): remove devMode question from plugins command #1786

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Jan 12, 2022

Changes

Removes the question

Do you want to allow dev mode for slots? (Don't use for production!)

as it is hard for new members to answer that. Advanced users can still access that by invoking yarn shopware-pwa plugins --devMode but our recommendation would be to use VueDevtools to discover plugin slots

image

@patzick patzick requested a review from mkucmus January 12, 2022 12:56
@vercel
Copy link

vercel bot commented Jan 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/AMHPjfeWJURyzDxZKY13QfsZTYfa
✅ Preview: Canceled

@github-actions
Copy link

💙 shopware-pwa-canary successfully deployed at https://f8922b94644559e1b0318d3cc888638d20676f49.shopware-pwa-canary.preview.storefrontcloud.io

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less code less troubles ;)

@patzick patzick merged commit 894ea98 into master Jan 19, 2022
@patzick patzick deleted the feat/cli-remove-devmode-question branch January 19, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants