Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/172-fix-the-docs-plugin #192

Merged
merged 39 commits into from
Dec 6, 2019
Merged

fix/172-fix-the-docs-plugin #192

merged 39 commits into from
Dec 6, 2019

Conversation

rmakara
Copy link
Collaborator

@rmakara rmakara commented Dec 5, 2019

Context
After a few updates of the dependencies docs:build started failing. Author of typedoc-plugin-markdown published a fix for that.

Purpose of that pull request is to verify our pipeline if it correctly publishes the docs.

Dependencies (no links)

  • tom-grey / typedoc-plugin-markdown / issues / 103

Changes

  • Updated version of typedoc-plugin-markdown.
  • Deleted estimations from definition of ready as we do not do that and it is hard to manage estimations in Github issues.
  • Deleted technical requirements from definition of ready as noone had a very clear vision on what that means. We stick to acceptance criteria and easy-going technical explanation. Usually that deep technical explanation is actually the result of the spike.

@github-actions
Copy link

github-actions bot commented Dec 5, 2019

Deploy preview for website ready!

Built with commit c9948b8

https://shopware-pwa-qksm9tl0r.now.sh

@rmakara rmakara requested a review from patzick December 6, 2019 07:14
@patzick patzick merged commit 194647d into master Dec 6, 2019
@patzick patzick deleted the fix/172-fix-the-docs-plugin branch December 6, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants