Merge pull request #2947 from vuestorefront/fix--sf-select-placeholde…

…r-attributes fix(SfSelect): disabled state attributes [SFUI2-1307]
vuestorefront · Aug 8, 2023 · 3ef44b5 · 3ef44b5
2 parents 12622cd + 7d851e9
commit 3ef44b5
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/.changeset/wise-bananas-build.md b/.changeset/wise-bananas-build.md
@@ -0,0 +1,6 @@
+---
+'@storefront-ui/react': patch
+'@storefront-ui/vue': patch
+---
+
+Remove redundant `selected` attribute from `SfSelect` placeholder
diff --git a/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx b/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx
@@ -64,7 +64,6 @@ export default function SfSelect(props: SfSelectProps) {
  {placeholder && (
  <option
  disabled
- selected
  hidden
  value=""
  className={classNames('bg-neutral-300 text-sm', {

diff --git a/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue b/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue
@@ -84,7 +84,6 @@ const modelProxy = computed({
  <option
  v-if="placeholder"
  disabled
- selected
  hidden
  class="text-sm bg-neutral-300"
  value=""

diff --git a/packages/tests/components/SfSelect/SfSelect.cy.tsx b/packages/tests/components/SfSelect/SfSelect.cy.tsx
@@ -99,7 +99,7 @@ describe('SfSelect', () => {
  it('should change value/modelValue', () => {
  initializeComponent();
 
- page().isNotDisabled().hasSelectedOption('red');
+ page().isNotDisabled().hasSelectedOption('blue');
  cy.then(() => {
  expect(onChangeSpy).calledOnceWith();
  page().makeSnapshot();