feat: productSlider [SFUI2-1190] #2819
Conversation
FRSgit
requested review from
Szymon-dziewonski,
dkacper and
mattmaribojoc
as code owners
🦋 Changeset detectedLatest commit: 6a06240 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Jakub Freisler <jakub@frsource.org>
FRSgit
force-pushed
the
feat/product-slider
branch
from
021a4d9
to
f322fa8
Compare
Signed-off-by: Jakub Freisler <jakub@frsource.org>
Signed-off-by: Jakub Freisler <jakub@frsource.org>
Signed-off-by: Jakub Freisler <jakub@frsource.org>
.changeset/lucky-papayas-reflect.md
Outdated
| '@storefront-ui/react': minor | ||
| --- | ||
|
|
||
| add ProductSlider block |
There was a problem hiding this comment.
Block is not part of our packages that we release on npm, so it should not be mentioned in changelog
There was a problem hiding this comment.
Yea, was wondering about that - how will we raise the version number when there are no changes to the package? 😄
There was a problem hiding this comment.
Sorry, I'm not sure if I understand, you did changes in component from package in scrollable.vue so you should make patch change only for vue package and write something like Prop typing change in SfScrollable, wdyt?
There was a problem hiding this comment.
Yup, I did it already yesterday: https://github.com/vuestorefront/storefront-ui/pull/2819/files#diff-d78d5a6ea45c0e27ea4974822b530c55251c860f32d1f9cb9435a4d09d575cc8R2-R5
But what I mean - we need to release the vue/react packages with 2.4 next week - how do we do that?
There was a problem hiding this comment.
I've remove this changelog. But the issue of "how and when to set version at 2.4" still persists 😄
There was a problem hiding this comment.
With what I test today changesets bump version to 2.4 so at this point we need to only go with current new flow and at the end run yarn publish by hand and thats it
There was a problem hiding this comment.
yea, but we need to make sure that we will always have a minor bump somewhere in our tasks 😄
There was a problem hiding this comment.
Thats true, we have to be aware what kind of tickets we do, but so far its looking good, we have some breaking change tickets and one commit already land to different branch so i think we are good here
Co-authored-by: Szymon Dziewoński <szymon.dziewonski@gmail.com>
Signed-off-by: Jakub Freisler <jakub@frsource.org>
|
[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!
|
|
[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!
|
Related issue
Closes https://vsf.atlassian.net/browse/SFUI2-1190\
Checklist