Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rating button #2820

Merged
merged 9 commits into from
Jun 15, 2023
Merged

feat: rating button #2820

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c91f449
feat: add RatingButton base component
dkacper Jun 13, 2023
2e49562
Merge branch 'v2-develop' of github.com:vuestorefront/storefront-ui i…
dkacper Jun 13, 2023
8627f44
Merge branch 'v2-develop' of github.com:vuestorefront/storefront-ui i…
dkacper Jun 14, 2023
5eed580
fix: adjust RadioButton api
dkacper Jun 14, 2023
0936c22
fix: adjust RatingButton showcases
dkacper Jun 14, 2023
8a4260c
fix: test of children
dkacper Jun 14, 2023
bc186bf
test: remove default values of props
dkacper Jun 14, 2023
d581d2a
fix: rating button v-model
dkacper Jun 14, 2023
47bea10
fix: test interface import
dkacper Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 15 additions & 25 deletions packages/tests/components/SfRatingButton/SfRatingButton.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,29 @@
/// <reference path="../../../../node_modules/@percy/cypress/types/index.d.ts" />
import React from 'react';
import { SfRatingButtonSize, noop } from '@storefront-ui/shared';
import { SfRatingButtonSize } from '@storefront-ui/shared';
import { mount, useComponent } from '../../utils/mount';

const { vue: SfRatingButtonVue, react: SfRatingButtonReact } = useComponent('SfRatingButton');
import SfRatingButtonBaseObject from './SfRatingButton.PageObject';
import { isReact } from '../../utils/utils';

interface Props {
value?: number;
onChange?: (value: number) => void;
max?: number;
name?: string;
disabled?: boolean;
label?: string;
labelClassName?: string;
size?: `${SfRatingButtonSize}`;
getLabelText?: (value: number) => string;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: those are copy paste from https://github.com/vuestorefront/storefront-ui/pull/2820/files#diff-8fcdae6ac93bc10b998e13c1280c073dd3e3ff2cac241eafea1e74d5ebe84ca0R13 why not reuse those ?

describe('SfRatingButton', () => {
const page = () => new SfRatingButtonBaseObject('ratingbutton');

const initializeComponent = (
props: {
value?: number;
onChange?: (value: number) => void;
max?: number;
name?: string;
disabled?: boolean;
label?: string;
size?: SfRatingButtonSize;
getLabelText?: (value: number) => string;
children?: () => JSX.Element;
} = {},
) => {
const {
value = 0,
onChange = noop,
max = 5,
name = 'sf-rating-button',
disabled = false,
label = 'Rating',
size = SfRatingButtonSize.base,
getLabelText = (value) => `${value} star`,
children,
} = props;
const initializeComponent = (props: Props = {}) => {
const { value, onChange, max, name, disabled, label, size, getLabelText, children } = props;
return mount({
vue: {
component: SfRatingButtonVue,
Expand Down