Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: example paths #3244

Merged
merged 4 commits into from
Nov 15, 2024
Merged

fix: example paths #3244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eee5940
chore: add proper redirects for non-prod docs envs
FRSgit Nov 12, 2024
b9958a7
chore: fixup docs dockerfile
FRSgit Nov 14, 2024
391a549
fix: example paths
FRSgit Nov 15, 2024
ab81261
Merge branch 'v2-develop' into fix/example-paths
FRSgit Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .vuestorefrontcloud/docs/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ ARG VITE_DOCS_EXAMPLES_REACT_PATH
ARG VITE_DOCS_EXAMPLES_VUE_PATH
ARG ENVIRONMENT

ENV VITE_DOCS_BASEPATH=$VITE_DOCS_BASEPATH
ENV NUXT_DOCS_BASEPATH=$VITE_DOCS_BASEPATH
ENV NUXT_APP_BASE_URL=$VITE_DOCS_BASEPATH
ENV VITE_DOCS_EXAMPLES_REACT_PATH=$VITE_DOCS_EXAMPLES_REACT_PATH
ENV VITE_DOCS_EXAMPLES_VUE_PATH=$VITE_DOCS_EXAMPLES_VUE_PATH
ENV NUXT_DOCS_EXAMPLES_REACT_PATH=$VITE_DOCS_EXAMPLES_REACT_PATH
ENV NUXT_DOCS_EXAMPLES_VUE_PATH=$VITE_DOCS_EXAMPLES_VUE_PATH
ENV ENVIRONMENT=$ENVIRONMENT

RUN yarn
Expand Down
6 changes: 3 additions & 3 deletions apps/docs/components/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
VITE_DOCS_EXAMPLES_VUE_PATH=http://localhost:3001
VITE_DOCS_EXAMPLES_REACT_PATH=http://localhost:3002
VITE_DOCS_BASEPATH=/v2
NUXT_DOCS_EXAMPLES_VUE_PATH=http://localhost:3001
NUXT_DOCS_EXAMPLES_REACT_PATH=http://localhost:3002
NUXT_DOCS_BASEPATH=/v2
4 changes: 2 additions & 2 deletions apps/docs/components/nuxt.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ export default defineNuxtConfig({
runtimeConfig: {
public: {
storefrontUi: true,
DOCS_EXAMPLES_VUE_PATH: process.env.VITE_DOCS_EXAMPLES_VUE_PATH,
DOCS_EXAMPLES_REACT_PATH: process.env.VITE_DOCS_EXAMPLES_REACT_PATH,
DOCS_EXAMPLES_VUE_PATH: process.env.NUXT_DOCS_EXAMPLES_VUE_PATH,
DOCS_EXAMPLES_REACT_PATH: process.env.NUXT_DOCS_EXAMPLES_REACT_PATH,
siteUrl: process.env.NUXT_PUBLIC_SITE_URL || 'https://docs.storefrontui.io',
siteName: 'Storefront UI',
siteDescription: 'Fast, accessible, and fully customizable components built for e-commerce.',
Expand Down
Loading