[fix] fixed wrong env example #36
Conversation
.env.example
Outdated
| @@ -4,7 +4,7 @@ VSF_NUXT_APP_HOST=localhost | |||
|
|
|||
| VSF_STORE_URL=https://localhost:3000 | |||
| VSF_MIDDLEWARE_URL=https://localhost:3000/api/ | |||
| VSF_SSR_MIDDLEWARE_URL=http://localhost:3000/api/ | |||
| VSF_SSR_MIDDLEWARE_URL=https://localhost:3000/api/ | |||
There was a problem hiding this comment.
@skirianov
Hello, thank you for your PR. However, there are no wrong or good examples when it comes to the used protocol. In fact, 99% of local setups will not use HTTPS in their Nuxt application, it should be more like https=>http for middleware_url than http=>https for ssr_middleware_url
There was a problem hiding this comment.
Following our documentation https://docs.vuestorefront.io/magento/installation-setup/configure-integration.html#_5-using-https-configuration-for-a-local-development setting up the HTTPS seems like a part of the process. Hence, our users may get confused and run into issues (I've got confused and got stuck for a while because of it). That's why we need to fix it according to docs or change docs to remove Step 5 and make it optional @mattmaribojoc
Sergii Kirianov
Developer Advocate
Vue Storefront
There was a problem hiding this comment.
It should be optional, ppl do not understand how and why to configure a secure connection for local development. I thought that the title makes it obvious it is optional, but that was the wrong assumption.
There was a problem hiding this comment.
we have already a few people struggling with it. So, what do you suggest? Keep it http and change docs to make it optional?
There was a problem hiding this comment.
Yes, it was already configured by default to use https and I had 1000question/day on how to setup it. Then I decided to make it unsecure by default (which is actually the very basic thing for the nuxt, security connection for the nuxt is always optional)
There was a problem hiding this comment.
@bartoszherba changed all to http and also changed this https://github.com/vuestorefront/template-magento/pull/36/files#r1082416684
There was a problem hiding this comment.
@mattmaribojoc please change docs accordingly and make https://docs.vuestorefront.io/magento/installation-setup/configure-integration.html#_5-using-https-configuration-for-a-local-development this step 5 as an optional step after yarn dev section
…URL to be consistent
| VSF_STORE_URL=https://localhost:3000 | ||
| VSF_MIDDLEWARE_URL=https://localhost:3000/api/ | ||
| VSF_STORE_URL=http://localhost:3000 | ||
| VSF_MIDDLEWARE_URL=http://localhost:3000/api/ |
| VSF_SSR_MIDDLEWARE_URL=http://localhost:3000/api/ | ||
|
|
||
| VSF_MAGENTO_BASE_URL={YOUR_SITE_FRONT_URL} | ||
| VSF_MAGENTO_GRAPHQL_URL=https://{YOUR_SITE_FRONT_URL}/graphql | ||
| VSF_MAGENTO_GRAPHQL_URL={YOUR_SITE_FRONT_URL}/graphql |
There was a problem hiding this comment.
all {YOUR_SITE_FRONT_URL} consistent throughout the env file
Fixed wrong ENV variable example. It was breaking newly installed application.
Related Issue: #35