Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Corrected displayed the ratings stars. #525

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dimasch
Copy link
Contributor

@dimasch dimasch commented Oct 20, 2020

Related Issues

Closes #524

Short Description and Why It's Useful

Will loads actual review from ElasticSearch.

Screenshots of Visual Changes before/after (If There Are Any)

Before:
Снимок экрана 2020-10-20 в 18 18 30

After:
Снимок экрана 2020-10-20 в 18 30 05

Contribution and Currently Important Rules Acceptance

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dsitovs
Copy link

dsitovs commented Oct 30, 2020

review.ratings.length > 0 ? review.ratings[0].value

I think this should be calculating the average rating value based on the number of reviews rather than taking the first rating value.

@dimasch
Copy link
Contributor Author

dimasch commented Oct 30, 2020

@dsitovs Yes, possible, m2 supports a multiple review criteria.
Снимок экрана 2020-10-30 в 17 22 05

@dimasch
Copy link
Contributor Author

dimasch commented Oct 30, 2020

This is solution will works for one super criteria of rating, if send from frontend for one stars line.

@dimasch
Copy link
Contributor Author

dimasch commented Oct 30, 2020

In SF UI missing the rating control for send rating, and not possible to implement sending start, but i can add to merge request solution based on https://www.npmjs.com/package/vue-star-rating

Copy link
Collaborator

@Fifciu Fifciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great but please resolve conflict in changelog

@AishwaryShrivastav
Copy link
Contributor

Hey @dimasch , please update the change logs, the changes looks good.

@dimasch
Copy link
Contributor Author

dimasch commented Apr 13, 2021

@AishwaryShrivastav Okay, sorry. I will try today.

@AishwaryShrivastav
Copy link
Contributor

@AishwaryShrivastav Okay, sorry. I will try today.

No rush, you can do it 2 -3 days
Thanks for your reply

@dt2patel
Copy link
Collaborator

dt2patel commented Sep 6, 2021

@dimasch, long time no see. I'll get this merged asap if you can resolve this change log. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Hardcoded summary rating on product page.
7 participants