This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
Improved: code to apply the filter on all the category pages (#561) #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maintained the changelog for this PR here: #573 |
Fifciu
suggested changes
Jan 7, 2021
pages/Category.vue
Outdated
| @@ -530,6 +530,7 @@ export default { | |||
| } | |||
| }, | |||
| changeFilter (filter) { | |||
| delete this.$route.query.page | |||
There was a problem hiding this comment.
I think it is not a proper approach. You shouldn't modify this.$route.query object this way. Only via push or replace method. Please think about a different approach
There was a problem hiding this comment.
@Fifciu Solved the issue by updating the filterHelpers.ts file in catalog-next module.
PR: vuestorefront/vue-storefront#5396
|
|
ymaheshwari1
force-pushed
the
#561/unable-to-apply-filter-on-category-page
branch
from
3d95628 to
17837db
Compare
|
Closing this PR as the code improvements for the issue has been handled in the vue storefront PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#561
Closes #561
Short Description and Why It's Useful
The changes will remove the page number from the route which is causing the page change instead of product update.
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance