Skip to content
This repository has been archived by the owner on May 28, 2023. It is now read-only.

[2310-msi] Default stockId and from storeView. #227

Merged
merged 3 commits into from
Apr 30, 2019
Merged

[2310-msi] Default stockId and from storeView. #227

merged 3 commits into from
Apr 30, 2019

Conversation

dimasch
Copy link
Contributor

@dimasch dimasch commented Apr 29, 2019

+ @pkarw

Copy link
Contributor

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the default stock is should be taken from the config

@@ -36,6 +36,7 @@ function getMagentoDefaultConfig(storeCode) {
MAGENTO_ACCESS_TOKEN: apiConfig.accessToken,
MAGENTO_ACCESS_TOKEN_SECRET: apiConfig.accessTokenSecret,
MAGENTO_URL: apiConfig.url,
MAGENTO_MSI_STOCK_ID: 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be rather: config.msi.defaultStockId

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkarw Fixed.

@pkarw
Copy link
Contributor

pkarw commented Apr 30, 2019

@dimasch can You please just fix the failing CI - https://travis-ci.org/DivanteLtd/vue-storefront-api/jobs/526288380 ?

@dimasch
Copy link
Contributor Author

dimasch commented Apr 30, 2019

2019-04-30_11-13-49
Yes, ok, one minute.

@dimasch
Copy link
Contributor Author

dimasch commented Apr 30, 2019

@pkarw Fixed eslint error.

@pkarw pkarw merged commit ea07365 into vuestorefront:develop Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants