Merge pull request #2217 from pkarw/develop

Hofix: Improved offline mode handlers
vuestorefront · Jan 16, 2019 · 9dcda73 · 9dcda73
2 parents c69f2b8 + 2ab4855
commit 9dcda73
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 16 deletions.
diff --git a/core/pages/Category.js b/core/pages/Category.js
@@ -1,6 +1,7 @@
 import Vue from 'vue'
 import toString from 'lodash-es/toString'
 
+import i18n from '@vue-storefront/i18n'
 import store from '@vue-storefront/store'
 import EventBus from '@vue-storefront/core/compatibility/plugins/event-bus'
 import { baseFilterProductsQuery, buildFilterProductsQuery } from '@vue-storefront/core/helpers'
@@ -252,6 +253,15 @@ export default {
           this.$store.dispatch('category/products', this.getCurrentCategoryProductQuery)
           EventBus.$emitFilter('category-after-load', { store: this.$store, route: this.$route })
         }
+      }).catch(err => {
+        if (err.message.indexOf('query returned empty result') > 0) {
+          this.$store.dispatch('notification/spawnNotification', {
+            type: 'error',
+            message: i18n.t('The product, category or CMS page is not available in Offline mode. Redirecting to Home.'),
+            action1: { label: i18n.t('OK') }
+          })
+          this.$router.push(localizedRoute('/', currentStoreView().storeCode))
+        }
       })
     },
     onUserPricesRefreshed () {

diff --git a/core/store/lib/search.ts b/core/store/lib/search.ts
@@ -61,22 +61,6 @@ export const quickSearchByQuery  = async ({ query, start = 0, size = 50, entityT
         resolve(res)
         console.debug('Result from cache for ' + cacheKey + ' (' + entityType + '), ms=' + (new Date().getTime() - benchmarkTime.getTime()))
         servedFromCache = true
-      } else {
-        if (!isOnline()) {
-          console.debug('No results and offline ' + cacheKey + ' (' + entityType + '), ms=' + (new Date().getTime() - benchmarkTime.getTime()))
-          res = {
-            items: [],
-            total: 0,
-            start: 0,
-            perPage: 0,
-            aggregations: {},
-            offline: true,
-            cache: true,
-            noresults: true
-          }
-          servedFromCache = true
-          resolve(res)
-        }
       }
     }).catch((err) => {
       console.error('Cannot read cache for ' + cacheKey + ', ' + err)
@@ -109,6 +93,20 @@ export const quickSearchByQuery  = async ({ query, start = 0, size = 50, entityT
         }
       }
     }).catch(err => {
+      if (!servedFromCache) {
+        console.debug('No results and offline ' + cacheKey + ' (' + entityType + '), ms=' + (new Date().getTime() - benchmarkTime.getTime()))
+        const res = {
+          items: [],
+          total: 0,
+          start: 0,
+          perPage: 0,
+          aggregations: {},
+          offline: true,
+          cache: true,
+          noresults: true
+        }
+        resolve(res)
+      }
       reject(err)
     })
   })