Cart Configurable item pulled from magento loaded as Simple

[valeriish]

Steps to reproduce the issue

1. Login-in as customer
2. Add configurable product to cart
3. Examine minicart, new item have parent name, image, url, type = configurable
4. Login-out and login-in

Expected behavior

Cart item have type 'configurable'.
Name, image, etc are getting from assigned parent product

Current behavior

Cart item have type 'simple'.
Cart item displays name, image, etc of 'not visible individually' current simple product

Can you handle fixing this bug by yourself?

Yes
Issue: cart item is loading by serverItem.sku after ServerPull for configurable item

[pkarw]

Thanks, how would You like to fix this one? Please feel free to report a Pull Request

[valeriish]

After testing i found out that
rootStore.dispatch('product/single', { options: { sku: .. , childSku: ... }}) doesn't correct populate configurable item
For example: if i have 2 configurable item with same parent and different attribute value, afterServerPull return merged item with qty = 2 and only first attribute vaue
Workaround to fix it - add
if (actionOtions['childSku']) { rootStore.dispatch('product/configure', { product: product, configuration: { sku: actionOtions['childSku'] }, selectDefaultVariant: false, fallbackToDefaultWhenNoAvailable: false }).then((selectedVariant) => { resolve({ product: Object.assign({}, product, selectedVariant), serverItem: serverItem }) }) }
in servercartAfterPulled

but maybe better is fix 'product/single' method?

[pkarw]

Correct. Method “single” is not using the “childSku” at all as far as I remember (not being in front of my computer to check it right now ...) I think it makes sense to fix it at the origin - in the single action. However your fix is also just fine.

By this chance you might want to add code comments on how to use the action parameters correctly wdyt?

[valeriish]

This is workaround, i tried to update 'product/single' method, but it's affect on other logic.

[pkarw]

Thanks I’ll take a look at it later on I believe that we just should add a check if there is options.childSku set and pass this argument to configure some way but I must take a look at it

Your desired behavior is that call to single action will load parent product pointed out by ”sku” and them configure it to ”childSku” variant. Correct?

[valeriish]

Yes, you're correct

[pkarw]

Hmm I'm researching this issue and it seems like we're using options.childSku -> https://github.com/pkarw/vue-storefront/blob/011cd82c4285cd93b9bf3ed89f0279a41228d724/core/modules/catalog/store/product/actions.ts#L412

[pkarw]

It even seems to work - https://github.com/pkarw/vue-storefront/blob/011cd82c4285cd93b9bf3ed89f0279a41228d724/core/pages/Product.js#L215

hmm

[pkarw]

OK I found the problem and added an option assignDefaultVariant to have this side effect of the single - I mean the configured product as a result.

Now its:
single (context, { options, setCurrentProduct = true, selectDefaultVariant = true, assignDefaultVariant = false, key = 'sku', skipCache = false })

and in Your case You should call sth like:

dispatch('product/single', {
          options: actionOptions,
          assignDefaultVariant: true
        })

[valeriish]

Thank you!

servercartAfterPulled method was updated please review