Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with product pictures in offline mode (PLP and PDP) #2573

Closed
ArturDivante opened this issue Mar 8, 2019 · 7 comments
Closed

Problems with product pictures in offline mode (PLP and PDP) #2573

ArturDivante opened this issue Mar 8, 2019 · 7 comments
Assignees
Labels
5: Complex bug Bug reports P1: Urgent Priority mark - high priority QA approved after merge Testers will add this label after positive check on merged changes
Milestone

Comments

@ArturDivante
Copy link
Collaborator

Current behavior

  • After step 4: Product image blinks and disapears, if this product wasnt pre-loaded before going offline
  • After step 5: all pictures on PLP are replaced with the picture from last opened PDP.

Expected behavior

Pictures are displayed correctly in offline mode

Steps to reproduce the issue

  1. Go to https://test.storefrontcloud.io/
  2. Open women category
  3. Turn to offline mode
  4. Open any product page
  5. Go back to category page

(in attached video, 1st and 4th product were proeloaded - so they load correctly)
offline pictures bug

Repository

https://test.storefrontcloud.io/

Can you handle fixing this bug by yourself?

no

Environment details

  • Browser: Many
  • OS: Win10

Additional information

@ArturDivante ArturDivante added the bug Bug reports label Mar 8, 2019
@patzick patzick added this to the 1.9.0-rc.2 milestone Mar 8, 2019
@pkarw pkarw added the P1: Urgent Priority mark - high priority label Mar 8, 2019
@pkarw pkarw modified the milestones: 1.9.0-rc.2, 1.8.4 Mar 12, 2019
@patzick patzick mentioned this issue Mar 12, 2019
2 tasks
@patzick patzick modified the milestones: 1.8.4, 1.9.0-rc.2 Mar 12, 2019
@patzick patzick added 5: Complex QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Mar 12, 2019
@patzick patzick self-assigned this Mar 18, 2019
@patzick patzick closed this as completed Mar 18, 2019
@pkarw
Copy link
Collaborator

pkarw commented Apr 4, 2019

@patzick there is still a problem with offline images on next (works just fine on demo) - the low quality offline images are not used which causes two things:

  • when loading the image even when user is online there is no this specific proffrsssive loading effect that’s visible on demo (you get pixelated image and immediately afterwards the sharp one)
  • images are simply not displayed in the offline mode
    BC9A4C43-961B-4FA4-90F0-B1387536A764

@pkarw pkarw reopened this Apr 4, 2019
@pkarw
Copy link
Collaborator

pkarw commented Apr 4, 2019

Another thing - when switching colors it shouldn’t display the placeholder but stock to the thumbnail picture (offline image which is selected in product/single) - compared to demo (1.8.4) where it works exactly like that
5D1E6007-8486-453C-A400-624DEDEE095B

@pkarw
Copy link
Collaborator

pkarw commented Apr 4, 2019

Even I’m back online still images won’t work :-(

C3B4F262-E073-4161-96FC-B60CFFEDE9F2

@pkarw
Copy link
Collaborator

pkarw commented Apr 4, 2019

The same thumbnail should be used in the Microcart - need to be double checked

@ArturDivante
Copy link
Collaborator Author

Also, we still have returning issue - some products are not pre-loeaded for offline mode while they should, exactly like in #2543

  1. Open any category
  2. Turn to offline mode
  3. Try to open products from this category

Some of them are opened correctly, others throw an error. Problem is reproducable on test. Currently I have limited possibility to check on next, but it seem to be there as well. Demo environment is unaffected.

@patzick patzick modified the milestones: 1.9.0-rc.2, 1.9.0 Apr 8, 2019
@ArturDivante ArturDivante removed the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Apr 24, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Apr 26, 2019
@patzick
Copy link
Collaborator

patzick commented Apr 26, 2019

Fixed issue, when user is back online and not loaded images are still not showing.
Products caching will be fixed with #2682

@patzick patzick closed this as completed Apr 26, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels May 6, 2019
@alinadivante
Copy link
Collaborator

Fixed on release 1.9!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5: Complex bug Bug reports P1: Urgent Priority mark - high priority QA approved after merge Testers will add this label after positive check on merged changes
Projects
None yet
Development

No branches or pull requests

4 participants